ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Bump Serilog.Sinks.PeriodicBatching from 3.1.0 to 4.0.0 #166

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 4 months ago

Bumps Serilog.Sinks.PeriodicBatching from 3.1.0 to 4.0.0.

Release notes

Sourced from Serilog.Sinks.PeriodicBatching's releases.

v4.0.0

  • #60 - project/codebase maintenance (@​SimonCropp)
  • #63 - XDOC improvements (@​nblumhardt)
  • #66 - rewrite to remove all blocking/use async APIs entirely (@​nblumhardt)
    • breaking - target net462; netstandard2.0; net6.0
    • port to System.Threading.Channels
    • remove previously-deprecated inheritance-based API
Commits
  • b3821e5 Merge pull request #68 from serilog/dev
  • 773fdb6 Merge pull request #67 from nblumhardt/suppress-execution-context-flow
  • 010449c Prevent capturing of the sink-creation-time ExecutionContext by the batching ...
  • 180f5e7 Publishing key
  • 6455380 Merge pull request #66 from nblumhardt/modernize-again
  • 83f9133 Factor out SelfLog calls and improve formatting
  • 7983a13 Review feedback
  • 535a290 Comment explaining why the period-bounded batch filling loop is outside the t...
  • 9f2cea4 Inherit docs for IDisposable.Dispose()
  • 81b23fa Don't allow the run loop to be canceled before execution, since it violates t...
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ArieGato commented 4 months ago

@sungam3r Very strange... One test with the batch sink is failing. When I increase the timeout beyond the 2 second default period, the test finishes successful.

It would appear that the EagerlyEmitFirstEvent setting is ignored.

sungam3r commented 4 months ago

@nblumhardt can help with changes in batching sink.

ArieGato commented 4 months ago

I create an issue at the repo

https://github.com/serilog/serilog-sinks-periodicbatching/issues/70

sungam3r commented 4 months ago

@dependabot rebase

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (79614d3) to head (2d69404). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ========================================== - Coverage 96.70% 96.28% -0.42% ========================================== Files 8 8 Lines 485 485 Branches 45 45 ========================================== - Hits 469 467 -2 - Misses 7 9 +2 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sungam3r commented 4 months ago

Should be noted in breaking changes in changelog.