search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Add RabbitMQClientConfiguration.ClientProvidedName #181

Closed sungam3r closed 4 months ago

sungam3r commented 4 months ago

fixes #121 replaces #120

ArieGato commented 4 months ago

Do we want to support this setting through the AppSettings? e.g. Add the property to the costructor with all separate properties.

sungam3r commented 4 months ago

Done

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.12%. Comparing base (7813f58) to head (125eae8).

Files Patch % Lines
...bbitMQ/Sinks/RabbitMQ/RabbitMQConnectionFactory.cs 0.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #181 +/- ## ========================================== - Coverage 94.88% 94.12% -0.76% ========================================== Files 8 8 Lines 469 477 +8 Branches 42 43 +1 ========================================== + Hits 445 449 +4 - Misses 13 16 +3 - Partials 11 12 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sungam3r commented 4 months ago

All done here?