search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 52 forks source link

Remove MinVerTagPrefix #199

Closed sungam3r closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (5d42b64) to head (a39030d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #199 +/- ## ======================================= Coverage 96.28% 96.28% ======================================= Files 8 8 Lines 485 485 Branches 45 45 ======================================= Hits 467 467 Misses 9 9 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArieGato commented 6 months ago

Are you sure that the version will still be 7.0.0-pre…?

ArieGato commented 6 months ago

I prefer that the tags begin with a ‘v’. The Serilog repository also prefixes tags with a v

sungam3r commented 6 months ago

MinVerTagPrefix is useless if we will publish releases via GitHub releases.

ArieGato commented 6 months ago

So it supports v tags out of the box when we publish a release via github?

sungam3r commented 6 months ago

I mean it's YOU who decides to use one or another version/tag in https://github.com/ArieGato/serilog-sinks-rabbitmq/releases/new . GitHub Actions infrastructure places your tag on commit that triggers publish release workflow. MinVer then will just use tag from that commit as is. Of cource for all next commits from dev branches MinVer will increment version accordingly trimming leading v.

sungam3r commented 6 months ago

So it supports v tags out of the box when we publish a release via github?

No. OK. Let's go on with MinVerTagPrefix = v and will see how it works. I'm fine either way.