search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
56 stars 53 forks source link

Upgrade Serilog to 4.0.x #212

Closed ArieGato closed 1 month ago

ArieGato commented 2 months ago

fixes #210

ArieGato commented 2 months ago

@nblumhardt Could you take a look at this PR? I'm wondering if I implemented the new Periodic Batching and Wrapping Sink correctly.

nblumhardt commented 2 months ago

Hi @ArieGato,

The switch to the Serilog 4 batching configuration looks good 👍

I've been doing some work on a built-in fallback-logging implementation that seems like it would streamline how you're setting up failure sinks in this project; if you have a chance to check it out, any feedback over there would be really helpful: https://github.com/serilog/serilog/pull/2108

Cheers! Nick

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.26%. Comparing base (e0d3aed) to head (fa5fbf7). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #212 +/- ## ========================================== - Coverage 96.28% 96.26% -0.03% ========================================== Files 8 8 Lines 485 482 -3 Branches 45 45 ========================================== - Hits 467 464 -3 Misses 9 9 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.