search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Fix username guard to accept string.empty #38

Closed madslyng closed 7 years ago

madslyng commented 7 years ago

I also added changes to the CAI after the version bump, that I forgot to push

jaredcnance commented 7 years ago

From the current discussion in #37, do you think we should just do something like this for username/password:

username = string.IsNullOrEmpty(username) ? "guest" : username;

A quick test in the rabbit management plugin reveals that both username and password are required.

madslyng commented 7 years ago

I don't think we should make any changes. I think we should close this PR.

madslyng commented 7 years ago

Closing.