search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Dispose `RabbitMQClient` #39

Closed johannesegger closed 7 years ago

johannesegger commented 7 years ago

This PR fixes #34.

If you want to see the difference please pull this branch and run the console application (note that it requires VS2017).

The sample application starts a timer and logs a message periodically. When pressing Enter the logger is disposed and the application quits. No more logs are written.

Now try commenting out RabbitMQSink.Dispose and run the application again. You'll see that after pressing Enter the loggers are still outputting messages and the application doesn't really quit.

johannesegger commented 7 years ago

Haha, thanks, I just ripped your code out because I thought this project is dead. Thanks for accepting this.

madslyng commented 7 years ago

Sorry, I'm just very busy, and often miss if a PR comes in. I'm currently trying to get Appveyor build to work again after upgrading the solution to Visual Studio 2017. It should be up and running again after easter. :-)

johannesegger commented 7 years ago

Perfect, then I'll be able to use this library again.

madslyng commented 7 years ago

@johannesegger should be working now! Thanks for the PR.