search

ArieGato / serilog-sinks-rabbitmq

Serilog Sink for RabbitMq
Apache License 2.0
53 stars 51 forks source link

Bug/79 #80

Closed vpoorshab closed 5 years ago

vpoorshab commented 5 years ago

here is the possible fix for the issue #79 then the configuration should be like this :

{ "Name": "RabbitMQ", "Args": { "clientConfiguration": { "Hostnames": [ "" ], "Username": "", "Password": "", "Exchange": "", "ExchangeType": "", "DeliveryMode": "", "Port": }, "sinkConfiguration": { "textFormatter": "Serilog.Formatting.Compact.RenderedCompactJsonFormatter, Serilog.Formatting.Compact", "restrictedToMinimumLevel": "Warning" } } }

tsvetelintsonev commented 5 years ago

@vpoorshab thank you for submitting this PR. The provided fix in the PR will, unfortunately, result in a breaking change in the configuration API and since we already did a lot of changes in version 3 we would rather find a backward compatible solution. A new PR 81 with a fix for this issue is waiting for approval.