search

Ariel-Thomas / adventurers-league-log

A computerized log sheet for DnD 5e's Adventurer's League
55 stars 21 forks source link

Create/Edit Log - Currently Broken on Mobile #144

Closed feldoth closed 6 years ago

feldoth commented 6 years ago

The recent change to the text edit has caused a strange issue on mobile devices, when (what I assume is) the spellcheck functionality of the text editor kicks in mobile devices get stuck in a loop where the text highlighted in red is duplicated with every keypress, or touch event on the editor. This makes it impossible to create a new entry or edit an existing one, as the spellcheck has issues with words even as they are being typed.

Attaching a bluetooth keyboard fixes this issue, so it seems to be a problem with how touch input is handled. As a stopgap, disabling the spellcheck functionality of the editor would probably work - since pretty much all browsers have this built in anyway I doubt there's actually a need for it.

Picture of issue attached.

screenshot_20180731-121012

Ariel-Thomas commented 6 years ago

Good catch.

Ariel-Thomas commented 6 years ago

Should be fixed now. Let me know.

feldoth commented 6 years ago

Hmm, no - there's no more red highlighting but the effect persists despite that. No change other than the highlighting is gone. Thanks for the quick action though.

Ariel-Thomas commented 6 years ago

What sort of device are you using? I can't replicate this on my Galaxy S7

feldoth commented 6 years ago

I have a OnePlus One, no special customizations - it uses the SwiftKey keyboard in case that makes a difference. I'm using Chrome for my browser.

feldoth commented 6 years ago

Correction: SwiftKey is installed but wasn't activated - the stock android keyboard was in use. I swapped to SwiftKey and the problem went away, so it appears to be at least somewhat related to the stock keyboard.

Ariel-Thomas commented 6 years ago

This looks like your problem?: https://youtu.be/meSMATEj_foe ?

Ariel-Thomas commented 6 years ago

We can maybe switch to EasyMDE. It's a fork of the original SimpleMDE.

Ariel-Thomas commented 6 years ago

Okay, done. Let me know if that fixes the problem.

feldoth commented 6 years ago

That did the trick, I can now type normally using either keyboard. Thanks a bunch!

Ariel-Thomas commented 6 years ago

Thanks for working with me to get this fixed.