Ariel-Thomas / adventurers-league-log

A computerized log sheet for DnD 5e's Adventurer's League
55 stars 21 forks source link

DM rewards still support xp, needs to be shown #179

Closed derammo closed 6 years ago

derammo commented 6 years ago

Based on https://docs.google.com/document/d/1TnMfL6pMoQVKh4d51XWhBQYjVnKN3krq_k9e-CPGhlg/edit

Since you can still apply XP-based DM rewards to your characters conceptually before conversion, it needs to be possible to see what XP you have remaining and how much XP characters have, so you can properly "top them off."

This came up in Discord chat, as DMs are trying to apply their rewards to characters that haven't received any ACP yet, even though it is past August 30. Based on the linked rules document (warning: live document) it is still legal to apply XP and only then "convert" which is great because that's how your code works anyway. But right now, the site doesn't tell you that you still have XP to grant and how much XP characters have. Since showing XP is confusing to players, I think it would be best to have a click-through on the "Current Level" to show a details page that basically shows the calculation you did in the model, showing the XP, ACP from XP, and total ACP. That way, DMs can award XP rewards to those characters that don't have any direct ACP awards yet.

derammo commented 6 years ago

on the DM log entries, I would show XP stuff only if remaining unassigned XP > 0

for characters, I would always allow looking at the XP/ACP breakdown, even after ACP have been awarded, so people can go back and fix their records later

Ariel-Thomas commented 6 years ago

You can set what's displayed. Go to user details and choose from the dropdown to select old or both.

for characters, I would always allow looking at the XP/ACP breakdown, even after ACP have been awarded, so people can go back and fix their records later

This is already how it's implemented.

derammo commented 6 years ago

oops, sorry for wasting your time, I should have checked more carefully

On Aug 31, 2018, at 16:22, Ariel Thomas notifications@github.com<mailto:notifications@github.com> wrote:

Closed #179https://github.com/Ariel-Thomas/adventurers-league-log/issues/179.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Ariel-Thomas/adventurers-league-log/issues/179#event-1821419214, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAx4CHMU_JauYy-Rb88HiIjKLlcDRJaNks5uWZsWgaJpZM4WVuSx.