Ariel-Thomas / adventurers-league-log

A computerized log sheet for DnD 5e's Adventurer's League
55 stars 21 forks source link

There should be a way to remove magic items from your log. #57

Closed rooneg closed 7 years ago

rooneg commented 7 years ago

Under AL rules there are various ways to remove magic items from your item count (i.e. by using the last charge in a consumable item like Keoghtom's Ointment, or using all the charges in something like Wingwear that can only be recharged in particular adventures). There should be some way to log this in the web app so the used up item stops showing up in the item count.

Not that I'm about to use the last charge in a Keoghtom's Ointment or anything...

CosmicCandi commented 7 years ago

Rooneg, you can remove a magic item by going into the log where you received that item, editing the log, and then clicking the remove button. I can try to make the magic item field sortable on logs so you can order by the logs that have a magic item if it'd be helpful. That would make it easier to edit and remove the magic item.

rooneg commented 7 years ago

That will remove the item entirely. I want to remove it going forward while still having it on the historical log entries.

Ariel-Thomas commented 7 years ago

For now, it might be best to use the trade log to show loss of an item. If you don't fill in the details of the magic item you're trading for it's effectively null.

On Tue, Mar 7, 2017 at 6:38 AM, rooneg notifications@github.com wrote:

That will remove the item entirely. I want to remove it going forward while still having it on the historical log entries.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ariel-Thomas/adventurers-league-log/issues/57#issuecomment-284710370, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBKM5DOAKGkOVMH_qfCTkxoXwQO6RQaks5rjU_KgaJpZM4L_Ty0 .

-- -Ariel Thomas

"It's a peculiarity of the Norwegian culture and of the English and American, too, that men are not supposed to cry. Stiff upper lip and all that. But the Vikings cried like women in public or privately. They soaked their beards with tears and were not one bit ashamed about it. Yet, they were as quick to draw their swords as they were to shed tears. So, what's all this crap about men having to hold in their sorrow and grief and disappointment?" Philip Jose Farmer, Red Orc's Rage

rooneg commented 7 years ago

Oooh, good idea. I'll keep that in my back pocket for when I end up using up the item.

On Tue, Mar 7, 2017 at 9:29 AM, Ariel Thomas notifications@github.com wrote:

For now, it might be best to use the trade log to show loss of an item. If you don't fill in the details of the magic item you're trading for it's effectively null.

On Tue, Mar 7, 2017 at 6:38 AM, rooneg notifications@github.com wrote:

That will remove the item entirely. I want to remove it going forward while still having it on the historical log entries.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ariel-Thomas/adventurers-league-log/ issues/57#issuecomment-284710370, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBKM5DOAKGkOVMH_ qfCTkxoXwQO6RQaks5rjU_KgaJpZM4L_Ty0 .

-- -Ariel Thomas

"It's a peculiarity of the Norwegian culture and of the English and American, too, that men are not supposed to cry. Stiff upper lip and all that. But the Vikings cried like women in public or privately. They soaked their beards with tears and were not one bit ashamed about it. Yet, they were as quick to draw their swords as they were to shed tears. So, what's all this crap about men having to hold in their sorrow and grief and disappointment?" Philip Jose Farmer, Red Orc's Rage

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ariel-Thomas/adventurers-league-log/issues/57#issuecomment-284736544, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1sCVpKBMduObJg_FRH7RSfkoO1Cq4nks5rjWnWgaJpZM4L_Ty0 .

Ariel-Thomas commented 7 years ago

Considering just renaming the Trade Log to... Something related to magic items? Not entirely sure.

Ariel-Thomas commented 7 years ago

Okay, I'm thinking I may add an X to click next to magic items in your list that will spawn a trade log. That's easy to read the intention of and minimizes extra coding.