ArielMejiaDev / larapex-charts

A Laravel wrapper for apex charts
https://larapex-charts.netlify.app/
MIT License
290 stars 83 forks source link

Wrong publish command for chart stubs in the docs #79

Closed jivanf closed 10 months ago

jivanf commented 1 year ago

In the Customize chart stubs section of the docs, the following command is shown to publish the stubs:

php artisan vendor:publish --tag=larapex-charts-apexcharts-stubs

However, the tag used in the command doesn't exist. Instead, the larapex-charts-stubs tag needs to be used like this:

php artisan vendor:publish --tag=larapex-charts-stubs

I was looking to open a PR to fix this, but it seems the docs aren't in this repo, so I opened this issue instead.

JohnMSykes commented 1 year ago

Hi jivanf - Thanks for posting this - I was caught out by this issue, too. I can confirm that this command works with Larapex 6.0.0:

johnmsykes@Sykes-P16s:~/src/zmr$ sail artisan vendor:publish --tag=larapex-charts-stubs

   INFO  Publishing [larapex-charts-stubs] assets.

  Copying directory [vendor/arielmejiadev/larapex-charts/stubs/stubs] to [stubs] .......................................................... DONE

johnmsykes@Sykes-P16s:~/src/zmr$
ArielMejiaDev commented 10 months ago

Thanks @jivanf I am going to update the docs site as soon as possible, nice catch