Using code test tools and refactoring

ArielMejiaDev / larapex-charts

A Laravel wrapper for apex charts

https://larapex-charts.netlify.app/

MIT License

284 stars 84 forks source link

Using code test tools and refactoring #93

Closed marineusde closed 7 months ago

marineusde commented 7 months ago

@ArielMejiaDev this is a suggestion for better coding in the project

the package larastan check the code of errors or missing types with the configured level. you can run it with the command "composer phpstan"
the package pint check the code style with a "laravel standard" and removed unused classes in the code. you can run it with the command "composer pint-fix" to show the problems and "composer pint-fix to fix it

another idea is to run larastan and pint-fix in a pipeline after the push

ArielMejiaDev commented 7 months ago

I am going to close this PR as it takes too many changes, I have plans for the next release to use a phpStan and Pint using the Spatie Skeleton Package to update practices and get a better implementation and some new features too.