search

Arif-Khalid / pe

0 stars 0 forks source link

Error in Command Component Sequence Diagram #12

Open Arif-Khalid opened 1 year ago

Arif-Khalid commented 1 year ago

Lifelines should not continue past X deletions

image.png

nus-pe-bot commented 1 year ago

Team's Response

Thanks for pointing that out. But due to the limitation of PlantUML that we used. The lifeline does not end past deletion, but only at the end of the diagram.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

UML Object Deletion in DG

image.png

An X should be at the end of the lifeline of an object. The lifeline should not continue beyond the X.

[original: nus-cs2113-AY2223S2/pe-interim#1524] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing that out. The lifelines should end at the destroy marker (X) but due to the limitation of PlantUML, the lifeline reaches the end of the diagram.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]