search

Arif-Khalid / pe

0 stars 0 forks source link

UI class diagram errors #19

Open Arif-Khalid opened 1 year ago

Arif-Khalid commented 1 year ago

UML is labelled abstract but is not abstract. In addition, the static methods in UI are not underlined in the class diagram. This could lead to serious misunderstanding for new developers. image.png

nus-pe-script commented 1 year ago

Team's Response

Thanks for pointing that out. I did not double check the class diagram with the code. But I don't think the severity would be high, because the IDE will catch that we are instantiating an abstract class and point us the error. Which can be easily changed.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]