Open Arif-Khalid opened 1 year ago
Hi this is intended. We did not try to solve this issue because we did not felt a need to do it. As long as the values entered by the user is correct (no rounding off issues or miscalculation of expenses), we do not try to rectify it. Having one decimal places although not the typical convention to represent money, the value that it is trying to represent is the same. If the user were to enter a value with 2 d.p, the total expense value will also show 2dp, hence there is no loss in accuracy of the amount.
as shown in the image, when I enter an expense of 4.5, the total expense shown is 4.5. There is no loss in precision of the value. When I added another expense with 4.55, the total expenses is now 9.05. The total expense now shows 2dp, which also does not result in any loss precision of the value. Hence we did not rectify the decimal problem.
Team chose [response.Rejected
]
Reason for disagreement: Yes while it might not affect functionality, that is not the be all end all of the program. The consistency especially with monetary values is important for readability for the users. Furthermore, your description of we didn't solve it because we didn't feel a need to is precisely the definition of response.notInScope, which is what it should be classified under.
If I do not add any single digit cents to my expenses, the total expenses show only one decimal place which is inconsistent with common displays of finances.![image.png](https://raw.githubusercontent.com/Arif-Khalid/pe/main/files/492b3558-410e-44af-9b3b-36627fdf9696.png)