search

Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
181 stars 36 forks source link

Bug: right click on adress bar makes some items of toolbar context menu inactive #328

Closed vitaliylag closed 7 years ago

vitaliylag commented 7 years ago

Steps to reproduce:

  1. Right click on adress bar
  2. Right click on any toolbar button, for example "Downloads".

Actual results:

Expected results:

Aris-t2 commented 7 years ago

I'm sorry, but this is no a bug, it is a breakage precaution. Items inside "address bar" would not get "moved to menu" or "removed from toolbar". Instead the whole address bar would be moved/removed (because CTR allows that, -> movable address bar) causing Firefox ui to break after a restart. Without knowing the correct files to edit or remove (inside browsers user profile) you won't be able to use Firefox anymore (without creating a new browser profile).

"Downloads" or any other default toolbar button is not inside address bar by default. There is nothing to move/remove from address bar without CTR installed either.

If you are using "Puzzle Toolbars" add-on for example and add buttons to PTs address bar content, "move to menu" and "remove from toolbar" work correctly for those buttons.

vitaliylag commented 7 years ago

Problem is that right click makes items inactive not in adress bar but almost in all browser. This is really annoying.

"Downloads" in not in address bar. It is in toolbar.

Tollbar has many buttons:

Please read steps to reproduce.

PS. I have no other extensions. I have only classic theme restorer extension.

vitaliylag commented 7 years ago

Also new bug: with Classic Theme Restorer enabled I can remove the menu button from toolbar

PS. It is not a big problem because I can choose "customize" from toolbar context menu or from Firefox Button > Settings and then return the menu button back.

Aris-t2 commented 7 years ago

I can not reproduce this issue. Never occurred in any test scenario for me. Please create a new browser profile and test again.

"Also new bug: with Classic Theme Restorer enabled I can remove the menu button from toolbar" This is not a bug, but a CTR feature. CTR allows this on purpose. Many users hated the new menu button and wanted it gone.

vitaliylag commented 7 years ago

PS. When you click second time items become active. You need right click on downloads button immediately after right click on adressbar.

PS. Bug appears at least in FF 52–55 but I guess bug is in all versions. I tested in Firefox, Firefox Beta, Firefox Developer Edition, Firefox Nightly.

Aris-t2 commented 7 years ago

OK, I will look into it. In the mean time just right click on a button in address bar (e.g. reload) before right clicking another toolbar button.

Aris-t2 commented 7 years ago

Test 1.6.4beta4 and report back: https://addons.mozilla.org/addon/classicthemerestorer/versions/1.6.4beta4

Aris-t2 commented 7 years ago

Fixed on latest beta and release version of CTR.

vitaliylag commented 7 years ago

Thanks, the bug is fixed but I found new bug with page_action.

In page_action context menu first 2 items are always inactive. See screenshot: https://files.tesuto.ru/bugs/ctr/page_action_2.png

PS. page_action is button in address bar in WebExtensions.

PS. In the sreenshot it is my own WebExtension. If you need I can send the link to the extension in few days.

vitaliylag commented 7 years ago

Also "move to menu" and "remove from toolbar" are active in page_action. After removing from toolbar and restarting the browser as you said UI was broken. I restored my profile from backup.

After moving to menu there was no problems: address bar just was in the right and I could move it to the left even after restarting the browser.

Aris-t2 commented 7 years ago

Send me link to your add-on or post one to any other add-on using page_action buttons in location bar.

Aris-t2 commented 7 years ago

Test current CTR beta. Both issues you mentioned should be gone: https://addons.mozilla.org/addon/classicthemerestorer/versions/1.6.5beta1