search

Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
181 stars 36 forks source link

#nav-bar[iconsize='large'] setting is not compatible with svg icon of WebExtensions #377

Closed magicp-github closed 6 years ago

magicp-github commented 6 years ago

Steps to reproduce:

  1. Launch Firefox 56 with CTR 1.7.2
  2. Load Add-on "Permissions Example" (https://github.com/mdn/webextensions-examples/tree/master/permissions)
  3. Set #nav-bar[iconsize='large']

Actual Results: Add-on Icon is too large. Firefox Screenshots icon too. ctr

Expected Results: Set max-width (24px?)

Aris-t2 commented 6 years ago

Any AMO add-ons affected?

/* WebExtension action & toggle buttons */
#nav-bar[iconsize="large"] .toolbarbutton-1[id*="-browser-action"] .toolbarbutton-icon,
#nav-bar[iconsize="large"] .toolbarbutton-1[id*="-browser-toggle"] .toolbarbutton-icon {
  width: 18px !important;  
  max-width: 18px !important;
}
magicp-github commented 6 years ago

Yes. emoji

Aris-t2 commented 6 years ago

The fix will be in next beta and release versions.

Aris-t2 commented 6 years ago

Fixed in CTR 1.7.3