"Add-on lists: show add-on version" conflicts with http://bugzil.la/612168

[JustOff]

When Add-on lists: show add-on version is enabled in Firefox 47-56, then changes introduced by bug 612168 are overwritten and restartless add-ons are never received the ADDON_UNINSTALL reason on uninstall, but ADDON_DISABLE (see bug 620541).

Here is test add-on: uninstall-test@Off.JustOff.xpi.zip

[Aris-t2]

I ran some tests on Firefox 56 and the add-on gets uninstalled identically with and without version number being active. The add-on does not get disabled when you uninstall it, so I have no idea what issue this might cause even, if it fires up the wrong reason. Extension page has to be reloaded/reopened for the add-on to disappear in both cases.

[JustOff]

Please run test add-on attached above and you will see in console that when Add-on lists: show add-on version is on, then both Disable and Remove results to ADDON_DISABLE reason and never ADDON_UNINSTALL.

This is because CTR doesn't have these changes from bug 612168 in it's extensions.xml used for FF 47-56.

[Aris-t2]

OK, I found what is causing this and will offer a fix on next update.

This was no real problem anyway. Look into default xml files uninstall method from Fx56:

// If uninstalling does not require a restart and the type doesn't // support undoing of restartless uninstalls, then we fake it by // just disabling it it, and doing the real uninstall later.

[JustOff]

OK, I found what is causing this and will offer a fix on next update.

Thank you!

This was no real problem anyway.

Actually it is a problem, because if an extension performs some cleanup on uninstall it will never be called, and that's how I found it.

[Aris-t2]

Install this beta https://addons.mozilla.org/addon/classicthemerestorer/versions/1.7.3.2beta2

[JustOff]

I confirm 1.7.3.2beta2 fixes the problem, tested with FF 52.5.0 ESR & Basilisk M1.