Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
181 stars 36 forks source link

[Customizing mode][Firefox/Waterfox 56] How to add spaces and separators? #383

Open Telmesomething opened 6 years ago

Telmesomething commented 6 years ago

After installing CTR in Waterfox 56, I'm unable to add spaces between the buttons on the toolbar. Dragging a space from the Customize menu takes it up there, but is doesn't remain in place. Same goes for flexible spaces.

In the top half of the attached screenshot a space has been dragged to the spot indicated by the red arrow, but after releasing the mouse button, the space has been removed and has reappeared in the Customize panel.

ctr_spaces

Here's what it looks like after closing the Customize menu.

ctr_spaces after closing custimize

Aris-t2 commented 6 years ago

Waterfox 56 and Firefox 56 do not support spaces, flexible spaces and separators anymore.

Telmesomething commented 6 years ago

Waterfox 56 and Firefox 56 do not support spaces, flexible spaces and separators anymore.

Thanks for letting me know Aris.

It's a real shame then that the Waterfox developer decided to base it on FF56 because not having the option to add separators in between toolbar buttons means that they're all cluttered up together.

mzso commented 6 years ago

@Telmesomething commented on 2017. dec. 3. 10:11 CET:

Waterfox 56 and Firefox 56 do not support spaces, flexible spaces and separators anymore.

Thanks for letting me know Aris.

It's a real shame then that the Waterfox developer decided to base it on FF56 because not having the option to add separators in between toolbar buttons means that they're all cluttered up together.

There's a workaround. Add them via their context menu, then you can move them.

grahamperrin commented 6 years ago

… unable to add …

Workaround

Whilst customising, use the contextual menu.

This screenshot was taken after adding a flexible space, divider and space:

2017-12-24 14 50 37 customize waterfox - waterfox

Postscript

Sorry for the duplication. https://github.com/Aris-t2/ClassicThemeRestorer/issues/383#issuecomment-353784978 above was not shown until after I had posted this comment. (Waterfox, like Firefox, suffers terribly from stale representations of content with sites such as GitHub.)

Telmesomething commented 6 years ago

There's a workaround. Add them via their context menu, then you can move them.

Whilst customising, use the contextual menu.

Magic! Just what the doctor ordered. Thanks very much mzso.

Many thanks also to grahamperrin for the screenshot.

Aris-t2 commented 6 years ago

I think we can keep this open so others can find this workaround too.

Telmesomething commented 6 years ago

I think we can keep this open so others can find this workaround too.

Just as well as it turns out. After adding spaces between toolbar buttons and then closing the Customization menu I noticed I'd missed one between two buttons. On reopening the Customize menu all the separators had disappeared.

However, after exiting Waterfox and restarting it again, they reappeared. So just a minor anomally.

mzso commented 6 years ago

@Telmesomething commented on 2017. dec. 25. 11:15 CET:

I think we can keep this open so others can find this workaround too.

Just as well as it turns out. After adding spaces between toolbar buttons and then closing the Customization menu I noticed I'd missed one between two buttons. On reopening the Customize menu all the separators had disappeared.

However, after exiting Waterfox and restarting it again, they reappeared. So just a minor anomally.

Yes. This his how it works on v56... You only have the separators the first time. After you switch tabs and back or close/open the customize tab the separators are gone for that session...

Aris-t2 commented 6 years ago

Firefox runs a code to remove those items once in customizing mode. We are lucky it fails the first time. A shame Waterfox team incorporated this into their browser as they are eager to keep Firefox' rubbish code out of their project.

mzso commented 6 years ago

@Aris-t2 commented on 2017. dec. 25. 13:07 CET:

Firefox runs a code to remove those items once in customizing mode. We are lucky it fails the first time. A shame Waterfox team incorporated this into their browser as they are eager to keep Firefox' rubbish code out of their project.

Judging by the answers of the WF dev it might be done in a future update.

Telmesomething commented 6 years ago

No need to be concerned about the post I made here yesterday Aris. It turned out to be a config setting namely privacy.resistFingerprinting. When set to true, Waterfox resizes itself on opening.

I managed to find it after creating a new profile and then restarting it every time I made a change either by adding an extension or making a config change.

jemonaff commented 6 years ago

Install "Classic Theme Restorer" then you can find the Flexble toolbar and Space and Separator. But They will disappear when you exit customize. If you want to find them, you reboot Waterfox. 2018-04-17__

mzso commented 6 years ago

@jemonaff commented on 2018. ápr. 17. 12:35 CEST:

Install "Classic Theme Restorer" then you can find the Flexble toolbar and Space and Separator.

But They will disappear when you exit customize.

If you want to find them, you reboot Waterfox.

All of this was discussed before, and it doesn't actually work completely. You can only use the context menu to add them. Also, naturally everyone has CTR installed already, this issue is filed for CTR.

vertigo220 commented 6 years ago

Hopefully this gets fixed, as it was very frustrating to deal with and wasted a lot of my time figuring it out, but the workaround described here was very helpful, so thank you! I didn't realize at first what was meant by it and thought the items had to be added in order, that it was an issue of not being able to move the spaces around. So I removed all my items then started re-adding them with spaces, and at that point I realized what was meant.

Edit: Also, another issue I've encountered is that adding certain items to toolbars (adding dual icon bookmark button with star and list icons to bookmarks toolbar and downthemall buttons to status bar/addon toolbar) makes the toolbars get much larger (their height increases). It fixes itself with a restart of the browser. I was going to add it as an issue, but it seems somewhat related to this issue, and I'm not sure if it's CTR-specific or not.

Aris-t2 commented 6 years ago

@vertigo220 Maybe contacting Waterfox developers to look into this might help. Waterfox 56 has the "issue" with special items like spaces and separators, because Firefox introduced a stupid change in version 56 and I doubt anyone at Mozilla ever though about this with Firefox 57 being right around the corner back then.

The icon issue might be related to a general icon problem, when internal icons or add-on icons switched to svg images or large images in general. This is another issue and I'm not sure, if there is real need to look into it, if a browser restart fixes the problem.

vertigo220 commented 6 years ago

@Aris-t2 I would agree it's not a high-priority since a restart fixes it, but I wasted a fair amount of time trying to figure out how to fix it before realizing that, and fixing the problem would avoid others having to deal with that as well. Anyways, hopefully by me mentioning it someone else will figure it out a little easier, and it might be useful to know if others have the issue without CTR or in other setups. I've added both the issues to my list of things to report.

Aris-t2 commented 6 years ago

Could you open a new bug for this and run some tests to ensure this issue can be reproduced step by step?

Use Firefox 56 portable or Waterfox 56 portable (creating a new browser profile), install CTR, install one of the affected add-ons and test, if the issue still occurs in that environment. (I'm asking for this, because I run a quick test with DownThemAll add-on and the mentioned issue did not occur for me).

vertigo220 commented 6 years ago

Well, I just tried with a fresh install and couldn't reproduce it. Not sure if it was a conflict with another addon or just some really obscure fluke bug or what, but since it doesn't seem to be readily reproducible and since it's fixed with a browser restart, and it hasn't recurred since, I'd say it's not worth worrying about. If someone else comes along with the same issue, maybe they can provide more info that can help narrow it down, but if nothing else hopefully this will help them figure out to restart their browser without spending as much time as I did trying to figure out other solutions.

grahamperrin commented 5 years ago

Could you open a new bug for this …

Do you mean, the disappearance (from available buttons) after first use of Customise?

Diverso1982 commented 5 years ago

I added separators instead of flexible spaces thanks to Aris' _flex_space_on_navbar_replace_withseparator.css. I resized them to 10px instead of 1px, that is perfect. And the last I need - how to change its' color? I need them to be fully transparent.

default

Aris-t2 commented 5 years ago

Fully transparent would make them invisible, but if that is what you are looking for, replace the "red" with "transparent":

#main-window:not([customizing]) #nav-bar toolbarspring {
  -moz-appearance: unset !important;
  min-width: 0px !important;
  max-width: 0px !important;
  border-right: 1px solid red !important;
  -moz-margin-start: 5px !important;
  -moz-margin-end: 5px !important;
}
Diverso1982 commented 5 years ago

Thank you! You are a magician!

grahamperrin commented 5 years ago

Workaround (a complementary legacy extension)

Puzzle Bars

In the Classic Add-ons Archive: