search

Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
181 stars 36 forks source link

[Basilisk browser] Spaces added to toolbar no longer movable #386

Closed Telmesomething closed 6 years ago

Telmesomething commented 6 years ago

As per the title spaces added to the toolbar in Basilisk cannot be moved anymore. Attempting to move them just moves the whole window now.

A workaround for this particular problem is to add two (or more) of them to the toolbar and then to move the button(s) in between them. Repeat as necessary to reposition buttons as desired.

Aris-t2 commented 6 years ago

Which toolbar are your spaces on and are they movable, if you enable/disable the titlebar in customizing mode.

I just tested Basilisk (2018-01-05) x64 (Win7x64) and all spaces, flexible spaces and separators on menubar, tabs toolbar, navigation toolbar, bookmarks toolbar and add-on bar are movable in customizing mode.

Telmesomething commented 6 years ago

Which toolbar are your spaces on and are they movable, if you enable/disable the titlebar in customizing mode.

Standard toolbar i.e. to the left and right of the location bar. can t_move_spaces

The only thing that's been changed is NoSquint Plus has been removed. According to various reviews of it on the Moz site the developer regularly adds expiration dates to older versions which causes it to stop working even after updating it to the latest version. I don't know if that would cause the non-movable separators problem though.

EDIT: I guess I'll have to try creating a new profile again.

Aris-t2 commented 6 years ago

You could try to reset your toolbar configuration by hitting "Restore defaults" button in customizing mode.

Also reset this preference: about:config > browser.uiCustomization.state

Removing add-ons should not break toolbar configuration like this.

Telmesomething commented 6 years ago

Well, I just created a new profile and only installed CTR, but the problem persists. The only difference between us is that I'm running Windows 8.1

EDIT: I tried it in Waterfox and they can be moved there without a problem.

Telmesomething commented 6 years ago

Also reset this preference: about:config > browser.uiCustomization.state

I just tried that, but no change.

I'll go disable my AV now to see if that's the cause.

Telmesomething commented 6 years ago

I found the cause of the problem which as nothing to do with AV.

Simply put, there's no need to move spaces, separators etc. Just drag & drop them from the customization menu and place them where you wish. They seem to stay put now. :)

Aris-t2 commented 6 years ago

Good to hear you solved this issue.

Out of curiosity I setup Basilisk and a new profile with CTR in Win8.1. No issue moving or drag&drop them anywhere.

basilisk

Telmesomething commented 6 years ago

Weird. They still can't be moved on my new profile. Also, after installing CTR on it, the back and forward buttons were missing.

new_profile_no_back-forward-buttons

No problem really since I could drag & drop those from the customization menu.

Aris-t2 commented 6 years ago

Not sure, but how exactly do your create a new profile? After creating one and installing CTR it has to look like on my screenshot. Yours already shows a bunch of active (CTR) settings. The goal behind creating new profiles is testing browsers default environment without any setting changes.

Telmesomething commented 6 years ago

I just follow standard practice as described here with the exception that firefox.exe -p is replaced with basilisk.exe -p

I usually name the new profile with something which represents whatever the problem is.

The only other change is to import CTR settings used in another profile which isn't experiencing any problems.

Aris-t2 commented 6 years ago

The only other change is to import CTR settings used in another profile which isn't experiencing any problems.

That is one of the main problems, that can occur and jeopardize new profile tests completely. There are tons of setting changes over different browser versions. Importing an "older" configuration not only adds add-on leftovers, but also toolbar configurations and errors saved inside previous about:config preferences.

A new profile means renaming / backing up the current profile folder and starting from 0 (downloading and configuring add-ons, configuring browser settings).

Telmesomething commented 6 years ago

Well, not really since I always export CTR settings from an existing profile before importing them into a new one. So in that respect, the settings will be the same.

What you're suggesting will be both time consuming and impractical since it will mean recreating all the settings all over again from scratch. There won't be much point in creating a CTR backup if it can't be used again.

Aris-t2 commented 6 years ago

Creating a new profile for testing should not be comfortable, fast or practical. The only purpose is testing a clean environment, which gets jeopardized by importing anything from a previous profile.

Again this is for testing only until confirming whether the error is present on a clean new profile or not. Afterwards things can be imported and tested further. This is the only way two or more users can compare setups and find what probably is causing an error.

Telmesomething commented 6 years ago

Creating a new profile for testing should not be comfortable, fast or practical. The only purpose is testing a clean environment, which gets jeopardized by importing anything from a previous profile.

Well, I suppose you have a point there so I created another new profile and then installed CTR in its bare bones state. This time spaces are indeed movable.

So here's the offending CTR prefs file which contains something which is causing that problem. CTRpreferences.txt

Telmesomething commented 6 years ago

I'll save you the trouble of looking for it. The problem arises when tabs are moved below the location bar. The actual setting is "Tabs not on top V2".

Aris-t2 commented 6 years ago

There is an easy solution, only use Tabs not on top v1.

1

Telmesomething commented 6 years ago

There is an easy solution, only use Tabs not on top v1.

Appreciate the response but it's not really necessary because spaces can be added simply by placing them via drag&drop. But I just thought I'd mention in my previous post that tabs below the location bar seemed to be the cause of the problem (to save you searching for it).

I notice though that V1 adds an additional spacing line between the menu bar and the location bar/addon buttons. I can't remember why I selected V2 before since it's too long ago. But I'll keep the V1 solution in mind just in case things go pear-shaped again. :)

Thanks for your help Aris.