Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
182 stars 36 forks source link

[old search][Waterfox 56.2] Alt-down stopped opening search engine list #390

Closed don-reba closed 6 years ago

don-reba commented 6 years ago

Alt-down used to open the search engine list in the old-style search bar, and it still does in the default, new version. But this shortcut no longer does anything in the old-style search bar, as of the last (or a very recent) update.

Waterfox 56.2.0 (64-bit)

Aris-t2 commented 6 years ago

Are you sure "Alt-down" feature was done by CTR? I don't recall seeing this feature ever in CTR.

I tested Firefox 52 ESR and Firefox 56 and both did not offer such a feature with CTR 1.7.4. You can however switch between search engines with Ctrl+Up/Down.

sasoph commented 6 years ago

Firefox 52 ESR (52.8.0esr-1) 64-bit: Alt+Down used to work with CTR pre 1.7.4 and old searchbar.

With 1.7.4 and old searchbar, Alt+Down just shows previous search terms.

With no CTR, Alt+Down behaves just like CTR 1.7.4 and new searchbar, showing previous search terms and an icon only search site list.

Ctrl+Up/Down is not useful, as cycling through all my search forms (many sites, not just engines) one by one, is tedious. Alt+Down shows the searchbar dropdown with the sitenames, (not just the icons as in the new search), which allows typing the first letter of the sitename to cycle through matching sites.

Aris-t2 commented 6 years ago

OK, this issue was caused by my latest code "cleanup" inside old search's xml file. Test this version: 1.7.4.1.

sasoph commented 6 years ago

1.7.4.1 restores Alt+Down for me.

Cheers.

don-reba commented 6 years ago

Can confirm the problem is fixed in 1.7.4.1.