Aris-t2 / ClassicThemeRestorer

Classic Theme Restorer for Australis UI (Firefox/Waterfox/Basilisk versions 45.x-56.x only!)
Mozilla Public License 2.0
181 stars 36 forks source link

Add-on Bar always reappears upon restart. #405

Closed Peacock365 closed 5 years ago

Peacock365 commented 5 years ago

As the title always says, the Add.on Bar always reappears upon browser restart, even if it was turned off via View --> Toolbar --> Add-on Bar.

Waterfox 56.2.9 Classic Theme Restorer 1.7.8.2019.02.10 macOS 10.14.4 Mojave

It should be noted that this behavior happens when one of the new WebExtension lightweight themes is used, here is such a theme:

https://addons.mozilla.org/de/firefox/addon/dark/?src=search

It should also be noted that the Add-on Bar is blacked out when such a theme is used, as if the theme is not being applied to it at all.

Please fix.

Aris-t2 commented 5 years ago

I cannot confirm this. In my tests the add-on bar does not reoccur after restart. Try to create a new browser profile and only install CTR.

Waterfox 56.2.9 Classic Theme Restorer 1.7.8.2019.02.10 macOS 10.14.4 Mojave Dark theme: https://addons.mozilla.org/de/firefox/addon/dark/

wf

(I can only test this in a VM, no Apple Hardware around here ;-))

Peacock365 commented 5 years ago

Never mind, in my case it does reappear every time I restart the browser, even if it was turned off before the restart takes place. Seems like a bug specific to my setup, eh?

I don't mind it, it is not a general bug of the add-on, and Waterfox will switch to a Firefox 68 ESR base in the mid-term anyway. By the way, do you plan to update the add-on for Waterfox 68? From the Waterfox subreddit, I know that Alex did implement all changes introduced by the Thunderbird team to ensure the continued compatibility of bootstrapped add-ons:

Waterfox 68 will also support WebExtensions Experiments by default. Will CTR be possible still?

Aris-t2 commented 5 years ago

If only bootstrapped add-ons will run on WF68+, then CTR won't be able to, because it only is an oldschool overlay add-on.

Many CTR features can be ported or recreated using bootstrapped add-ons, but I don't think I'm going to spend any time doing that. After all CTR is mostly dead. If Mozilla would have allowed this in Firefox like they did with Thunderbird, I might have ported a light version of CTR already back then, like happened with "CustomizeMyBird" for Thunderbird.

Peacock365 commented 5 years ago

It seems like Waterfox 68 still supports overlay extensions. Documentation is up:

I really hope CTR is being revived for Waterfox 68, fingers crossed!

Aris-t2 commented 5 years ago

If Waterfox 68 will still support overlay add-ons, CTR will not die and won't need to be revived. ;-)

No need to reopen the thread. I will still receive notification, if you post something here.

Peacock365 commented 5 years ago

The Waterfox 68 Alpha build should soon appear, hopefully CTR 2.0 is going to happen. I rely on it, and really hope it sees the light of the day.

Aris-t2 commented 5 years ago

Lets see what happens in WF68. Maybe CTR will work right away.

kn-yami commented 5 years ago

It will not work out of the box, because Waterfox 68 will require a webex-like manifest for overlay extensions.


BTW thanks for making this extension. I use it every day on Basilisk.

Aris-t2 commented 5 years ago

If required changes will only be reduced to rewriting/changing the manifest, I will update it.