Small bug in Squared Tabs Classic v.2 theme

[supraspecies]

There's a small bug in Squared Tabs Classic v.2 theme. Tabs go 1-2 pixels below the tab bar. It's a minor, but a very annoying glitch for me. I posted a screenshot.

http://s29.postimg.org/xne9sv4rb/Untitled_1.jpg

Could you please fix this? And preferably tell me what to adjust in "tabs_squaredc2.css" file (supposedly it's this file) to get rid of the issue asap, as I'm about to compile my customized version of Firefox.

Thank you for all the effort and a great extension.

[supraspecies]

Another issue with the same tab theme. Screenshot is taken from my Windows 7 computer this time.

http://s27.postimg.org/vlar8zpk3/issue_2.jpg

To the left is Squared Tabs Classic v.1. To the right is v2. As you can see, v.2 adds a lot of unused space. Would be great if it could be removed. Thank you. And again, if you can provide a CSS code to quickly fix the issue, that would be appreciated.

[supraspecies]

And another glitch. If you add New Tab "+" button at the end of the last tab in tab row (I did it via userChrome.css), then with Squared Tabs Classic v.2 and lots of open tabs (i disabled tab scrolling by setting MinWidth to 1 pixel), the tabs overlay the "+" button. That doesn't happen with Squared Tabs Classic v.1 theme.

[Aris-t2]

I will fix the glitch where tabs overlap with navigation toolbar on next CTR beta.

This Stylish code should fix it:

/*AGENT_SHEET*/
#TabsToolbar:not([tabsontop="false"]):not(:-moz-lwtheme) {
  margin-bottom:0px !important;
}

To reduce the gap at tab toolbars end in maximized mode for squared tabs v2 use this code in Stylish:

/*AGENT_SHEET*/
#main-window[sizemode="maximized"] #TabsToolbar {
  -moz-margin-end: -20px !important;
}

Tab toolbar dimensions do not get altered for squared tabs v2 in that case and match the default ones.

Not sure about the new tab "+" issue. Does it happen, if you switch to "default curved" tabs too? If not, post a screenshot and the code you are using.

Edit Try the new beta. https://addons.mozilla.org/addon/classicthemerestorer/versions/1.4.0beta5

[supraspecies]

Oh, sorry, didn't realize you answered to e-mail instead of GitHub. Yes, tabs overlay "+" button even in default theme. So it's not related to CTR in any way, I understand. Thank you very much for your support.

On Mon, Sep 21, 2015 at 4:06 PM, Aris notifications@github.com wrote:

I will fix the glitch where tabs overlap with navigation toolbar on next CTR beta.

To reduce the gap at tab toolbars end in maximized mode for squared tabs v2 use this code in Stylish:

/_AGENTSHEET/

main-window[sizemode="maximized"] #TabsToolbar {

-moz-margin-end: -20px !important; }

Tab toolbar dimensions do not get altered for squared tabs v2 in that case and match the default ones.

Not sure about the new tab "+" issue. Does it happen, if you switch to "default curved" tabs too? If not, post a screenshot and the code you are using.

— Reply to this email directly or view it on GitHub https://github.com/Aris-t2/ClassicThemeRestorer/issues/95#issuecomment-141968548 .

[supraspecies]

Just tried the code, editing theme CSS files directly (I don't use Stylish and I see no reason to install an extension I don't use). Everything works perfect. I made a few more adjustments to the code to remove absolutely all gaps in tab bar by example in Squared Tabs Classic v.1 theme. Now everything is perfect. Thank you very much for pointing me in the right direction and showing me how do it! The rest was easy to figure out.

Here's the complete code I use to remove all gaps:

titlebar-placeholder-on-TabsToolbar-for-captions-buttons{

-moz-margin-start: 0px !important; }

TabsToolbar:not([currentset*="tabbrowser-tabs,new-tab-button"]):not([orient="vertical"]) #tabbrowser-tabs:not([overflow]) {

-moz-margin-end: -15px !important; } .tabbrowser-arrowscrollbox > .arrowscrollbox-scrollbox { -moz-padding-start: 0px !important; }

This removes spaces after left "new tab" button, between tabs and arrow, and between arrow and minimize button. In fullscreen and windows mode. It's all your code. :) Again, thank you a lot!

[supraspecies]

Found another bug in the same theme (not related to my theme modifications, tried with original as well) - "List All Tabs" button is barely clickable when you use Windows Classic theme. Only clickable if you click the very right of it. Should happen in any OS, but I personally tested it in XP. Happens only in tab theme v.2, not in v.1.

CSS code to solve this would be appreciated, although I might figure it out myself now.

Thanks.

[Aris-t2]

Is "list all tabs" not clickable without your modifications?

[supraspecies]

Ok, forgive me - indeed my modifications are at fault. I forgot to reload Firefox after I did the testing. The problem is on my side, and I will figure it out. Again, thanks for your support and you can mark the topic as solved (or should I? I didn't find how to).

EDIT: Solved it. Did by comparing two themes. The proper code is:

titlebar-placeholder-on-TabsToolbar-for-captions-buttons{

-moz-margin-start: 0px !important; }

@media not all and (-moz-windows-classic) {

TabsToolbar[currentset_="tabbrowser-tabs,tabmixScrollBox"]:not([orient="vertical"]) .tabs-newtab-button + .tabs-newtab-button{

-moz-margin-start: 0px !important; }

TabsToolbar[currentset_="tabbrowser-tabs,tabmixScrollBox"]:not([orient="vertical"]) .tabs-newtab-button{

-moz-margin-end: 0px !important; }

TabsToolbar:not([currentset*="tabbrowser-tabs,new-tab-button"]):not([orient="vertical"]) #tabbrowser-tabs:not([overflow]) {

-moz-margin-end: -15px !important; } }

/* remove gaps before and after tabs */ .tabbrowser-arrowscrollbox > .arrowscrollbox-scrollbox { -moz-padding-start: 0px !important; }

[Aris-t2]

Well, editing files manually has to be repeated after every update, right? Stylish css tweaks will stay after update, so that is the easiest way imo.

The bug you are referring to is related to Windows XP and to Windows classic visual styles on Windows Vista and 7. I have not found a clean solution for that yet.

[supraspecies]

Ah, yes, that's a very point. I will definitely look into Stylish then.