[Firefox 65+] 'tabs below' / 'tabs not on top' changes

[Jgr9]

Ok, so I'm here (for the first time) after my Tabs Below the Nav Bar and Bookmark Bar userChrome code has apparently been broken again by the most recent Nightly. 20181106

I've tried yours, and if I've implemented it correctly (I'm kind of a novice), it also doesn't seem to have an effect. I haven't used a css folder and @import before, so I created one in the folder along with my userChrome and put your extra css in it. I uncommented the line in your userChrome, and also just tried the line all by itself. Like the code I have, it doesn't seem to be working anymore on the new Nightly, unless I did something wrong or there is something else that I need to do.

65.0a1 (2018-11-06) - 20181106 - Windows 64 bit

Oh and I'm just realizing now you're the CTR guy... lol

[Aris-t2]

Without the code I get this glitch:

Leaving the code shows things correctly:

[ArkadiuszMichalski]

Yes, in stable version, but like wrote above I use last Nightly74, don't know if this change will be needed in 73 or 74 (probably in 74 because for long time everything was ok, few days ago this appear).

[Aris-t2]

Overlooked that while testing on W7. ;-)

[Aris-t2]

I think we might get it working for all versions by modifying the code.

Change this:

#main-window[tabsintitlebar]:not([inDOMFullscreen="true"]):-moz-lwtheme #toolbar-menubar ~ #TabsToolbar .titlebar-buttonbox-container {
  display: block !important;
  margin-top: -13px !important;
}

to this:

#main-window[tabsintitlebar]:not([inDOMFullscreen="true"]):-moz-lwtheme #toolbar-menubar ~ #TabsToolbar .titlebar-buttonbox-container {
  display: flex !important;
}

[ArkadiuszMichalski]

If this one rule also work in FX72/73 then yes, I check flex rule in Nightly 74 and looks good, the same as block.

[ryuukenzenkou]

hey i want to request some help. i was using firefox 71 and everything was smooth, then updated to v72 and using your v3.0.0 CSS and the nightmare began. broken addon toolbar at bottom, tabs not working as they should, had to go through the code to fix firefox app button and so on... have a look here... i've tried everything that i could to fix these 2 issues, but no luck, so please help... the tab and the addon bar at bottom are the only thing that bug me.. (pun intended).. but if there's a way to fix it, ill be glad to know. btw ill share the CSS code in order to let you inspect it and check whats wrong. chrome.zip im not a programmer, but i do know a bit about the stuff as i am currently an student. please help.

edit: ill keep reading and trying to fix it on my own. edit2: using windows 7 pro x64, firefox v72 x64, default dark theme with aero enabled and no other tab addon installed. was working fine until firefox stable/release v71

[Aris-t2]

You initial screenshot pointed out, that layout.css.xul-box-display-values.survive-blockification.enabled was set to false on your system. This causes major issues even on default configuration without any modifications. Verify that pref is set to true inside about:config.

[fbnk]

Hi, is there any setting to get a bit more space between tabs and the fav bar? Plus there is a little space below the tabs, like they are "floating".

At the moment, this is the only tab related setting which is imported: @import "./css/tabs/tabs_below_navigation_toolbar_fx65_macOS_default_tabs.css"; /**/

Thanks!

FF 72.0.2 macOS 10.15 CustomCSSforFx 3.0.0

[Aris-t2]

Please use tabs_below_navigation_toolbar_fx65_macOS.css as workaround. Not sure what exactly changed on macOS atm, but it seems like tabs_below_navigation_toolbar_fx65_macOS_default_tabs.css might not be required anymore.

This code will increase the space between bookmarks toolbar and tabs toolbar in your config:

#navigator-toolbox #personal-bookmarks {
  padding-bottom: 20px !important;
}

[fbnk]

Thx for the quick reply! I guess the space is just fine now, after the switch :) And thx for the continuous development as well!

[ryuukenzenkou]

@Aris-t2 I'll change the values as you mentioned and see what happens. I'll reply soon as possible.

[Aris-t2]

I think we can close this one now. Fx 65 release was a long time ago ;-)