Aris-t2 / CustomCSSforFx

Custom CSS tweaks for Firefox
GNU General Public License v3.0
1.84k stars 181 forks source link

[Firefox 71+] Hide buttons on Extensions page #235

Closed Acid-Crash closed 4 years ago

Acid-Crash commented 4 years ago
  1. Describe the issue It seems like _addonlists_hide_report_buttonfx68.css and _addonlists_hide_manage_buttonfx68.css have stopped working on latest Nightly. The mentioned buttons are visible again. A rough analysis shows that a simple !important; might solve the issue

  2. What should have happened instead? Report and Manage buttons shouldn't be present

  3. Steps to reproduce the issue?

    • enable _addonlists_hide_report_buttonfx68.css and _addonlists_hide_manage_buttonfx68.css
    • go to about:addons
  4. SCREENSHOTS with/without this projects files (drag & drop images into this post) image

  5. System information

    • OS & OS version: Win10x64
    • OS theme name: ddefault
    • DPI / HiDPI resolution: 100
    • Firefox version: 71
    • Firefox theme / lw-theme: default
    • This projects settings the issue occurs with:
```css /* Firefox Quantum userContent.css tweaks ********************************************************/ /* code mostly taken from 'Classic Theme Restorer' & 'Classic Toolbar Buttons' add-ons **********/ /* Github: https://github.com/aris-t2/customcssforfx ********************************************/ /************************************************************************************************/ /************************************************************************************************* [!] Firefox 68+ (look for '_fx68') - new 'alternative appearance' option - new 'alternative appearance' option (AERO background color) - new 'restore version number' option for active add-ons - new 'compact appearance' option - new 'more compact appearance' option - new 'compact categories' option - new 'replace menu popup with buttons' option - new 'replace button labels with icons' option - new 'colorized icon' option for 'replace button labels with icons' option - new 'show buttons on hover only' option - new 'hide manage/expand button' option - new 'hide report button' option - old add-ons manager > show 'version number for add-ons' does not work with the html based add-on manager - old add-ons manager > show 'last update date' does not work with the html based add-on manager - old add-ons manager > alternative appearance does not work with the html based add-on manager - old add-ons manager > compact appearance does not work with the html based add-on manager - most old 'other' add-ons manager settings do not work with the html based add-on manager --> use 'about:config > extensions.htmlaboutaddons.enabled > false' temporary workaround for the old settings [!] Firefox 69+ - 'about:config > toolkit.legacyUserProfileCustomizations.stylesheets > true' (or custom styles will not be loaded) [!] Firefox 70+ - 'about:config > extensions.htmlaboutaddons.enabled > false' workaround does not work anymore *************************************************************************************************/ /************************************************************************************************* README Finding profile folder: address bar > about:support > Profile Folder > Open Folder CSS files and sub-folders belong into \PROFILEFOLDER\chrome\ directory. \chrome\config\ \chrome\css\ \chrome\image\ \chrome\userChrome.css \chrome\userContent.css ENABLING options: remove the combination of / and * before '@import' DISABLING options: add the combination of / and * before '@import' FIREFOX BUGS (nothing CSS code can do about): - some '@import' calls might not work properly on macOS and Linux - some '@import' calls might not work properly, if multi-process mode (e10s) is disabled - in both cases CSS code has to be added to userContent.css file manually Some CSS tweaks won't work, if '@namespace' references are used inside .css files! All options have significant categories and names. GENERAL SUPPORT / DISCUSSION THREAD: github.com/Aris-t2/CustomCSSforFx/issues/211 *************************************************************************************************/ /************************************************************************************************/ /* about:addons (settings split into different areas for Firefox 60-67, 68+ or 60-70+) **********/ /************************************************************************************************/ /* FIREFOX 68+ #################################################################################*/ /* addons page appearance - [only use one at a time] (incl. version number & buttons) ***********/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_fx68.css"; /**/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_aero_fx68.css"; /**/ /* <-- AERO colors */ /* version number for active add-ons [Fx 68+] ***************************************************/ @import "./css/aboutaddons/addonlists_show_addon_version_number_fx68.css"; /**/ /* compact item lists - [only use one at a time] ************************************************/ /* @import "./css/aboutaddons/addonlists_compact_fx68.css"; /**/ /* best with alternative_appearance_fx68 */ /* @import "./css/aboutaddons/addonlists_compact_more_compact_fx68.css"; /**/ /* best with alternative_appearance_fx68 */ /* button settings (requires addons_manager_alternative_appearance_fx68) ************************/ @import "./css/aboutaddons/addonlists_show_buttons_instead_of_menu_popup_fx68.css"; /**/ @import "./css/aboutaddons/addonlists_hide_report_button_fx68.css"; /**/ @import "./css/aboutaddons/addonlists_hide_manage_button_fx68.css"; /**/ /* @import "./css/aboutaddons/addonlists_replace_button_labels_with_icons_fx68.css"; /**/ /* @import "./css/aboutaddons/addonlists_colorized_button_icons_fx68.css"; /**/ /* requires replace_button_labels_with_icons option */ /* @import "./css/aboutaddons/addonlists_only_show_buttons_on_hover_fx68.css"; /**/ /* addons page appearance extra [requires one 'alternative appearance option' to be active] *****/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_compact_categories_fx68.css"; /**/ /* other settings *******************************************************************************/ /* @import "./css/aboutaddons/addonlists_hide_recommended_icon_fx68.css"; /**/ /* @import "./css/aboutaddons/addonlists_hide_allowed_in_private_windows_icon_fx68.css"; /**/ /* FIREFOX 60-67 ###############################################################################*/ /* NOTE: 'Version number for add-ons' will stop working soon when Mozilla drops XBL support. ***** See https://bugzilla.mozilla.org/show_bug.cgi?id=1397874 *******************************/ /* version number for add-ons [Fx 60-67] - [only use one at a time] *****************************/ /* [!] version number's xml file now restores add-on 'description' on Firefox 64+ ***************/ /* @import "./css/aboutaddons/addonlists_show_addon_version_number.css"; /**/ /* @import "./css/aboutaddons/addonlists_show_addon_version_number_hide_description.css"; /* show 'last updated' date for add-ons [Fx 60-67] - [only use one at a time] *******************/ /* @import "./css/aboutaddons/addonlists_show_addon_date_last_updated.css"; /**/ /* @import "./css/aboutaddons/addonlists_show_addon_date_last_updated_start_position.css"; /**/ /* addons page appearance [Fx 60-67] - [only use one at a time] *********************************/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance.css"; /**/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_aero.css"; /**/ /* <-- AERO colors */ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_v2.css"; /**/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_v2_aero.css"; /**/ /* <-- AERO colors */ /* addons page appearance extra [requires one 'alternative appearance option' to be active] *****/ /* @import "./css/aboutaddons/addons_manager_alternative_appearance_compact_categories.css"; /**/ /* compact item lists [Fx 60-67] - [only use one at a time] *************************************/ /* @import "./css/aboutaddons/addonlists_compact.css"; /**/ /* @import "./css/aboutaddons/addonlists_compact_more_compact.css"; /**/ /* other settings [Fx 60-67] ********************************************************************/ /* @import "./css/aboutaddons/addonlists_disabled_addons_colorized_icons.css"; /**/ /* @import "./css/aboutaddons/addonlists_disabled_tag_hidden.css"; /**/ /* @import "./css/aboutaddons/addonlists_only_show_buttons_on_hover.css"; /**/ /* @import "./css/aboutaddons/addonlists_replace_button_labels_with_icons.css"; /**/ /* @import "./css/aboutaddons/addonlists_move_button_to_start.css"; /**/ /* @import "./css/aboutaddons/addonlists_green_dot_hidden.css"; /**/ /* @import "./css/aboutaddons/details_page_alternative_content_order.css"; /**/ /* @import "./css/aboutaddons/details_page_switch_banner_label_position_for_themes.css"; /**/ /* @import "./css/aboutaddons/search_category_always_visible.css"; /**/ /* not for recent Fx versions */ /* FIREFOX 60-70+ ##############################################################################*/ @import "./css/aboutaddons/recentupdates_category_always_visible.css"; /**/ @import "./css/aboutaddons/addonlists_private_browsing_notice_hidden.css"; /**/ /************************************************************************************************/ /* about:preferences ****************************************************************************/ /************************************************************************************************/ /* preferences page appearance - [only use one at a time] ***************************************/ /* @import "./css/aboutpreferences/preferences_alternative_appearance.css"; /**/ /* @import "./css/aboutpreferences/preferences_alternative_appearance_aero.css"; /**/ /* <-- AERO colors */ /* @import "./css/aboutpreferences/preferences_alternative_appearance_v2.css"; /**/ /************************************************************************************************/ /* about:newtab / about:home ********************************************************************/ /************************************************************************************************/ /* a dark appearance for inbuilt 'Dark' theme is present by default in Firefox 61+ **************/ /* @import "./css/aboutnewtab/dark_appearance.css"; /**/ /* alternative background color for about:newtab/home pages 'Dark' theme present in Firefox 61+ */ /* @import "./css/aboutnewtab/dark_appearance_alternative_background.css"; /**/ /************************************************************************************************/ /* about:config (Firefox 67+) *******************************************************************/ /************************************************************************************************/ /* @import "./css/aboutconfig/aboutconfig_compact_appearance.css"; /**/ /************************************************************************************************/ /* WEB CONTENT **********************************************************************************/ /************************************************************************************************/ /* top level image on white background - [only use one at a time] *******************************/ /* [!] this settings can sometimes cause glitches ***********************************************/ /* @import "./css/webcontent/toplevel_image_classic_v1.css"; /**/ /* @import "./css/webcontent/toplevel_image_classic_v2.css"; /**/ /* Screenshots - internal browser add-on ********************************************************/ /* @import "./css/webcontent/screenshots_alternative_save_ui.css"; /**/ /* CUSTOM SCROLLBARS VARIABLES (Firefox 63+ only) - EXPERIMENTAL ********************************/ /* [!] Might not work on every page! This issue is for Mozilla to solve. ************************/ /* [!] not compatible with custom scrollbar JavaScipt userChrome scripts ************************/ /* [!] custom size values only compatible with 'web content' scrollbars at the moment ***********/ /* [!] more info inside 'custom_scrollbar_appearance.css' file **********************************/ /* @import "./config/custom_scrollbar_appearance.css"; /**/ /* <--- EXPERIMENTAL */ /* Autofill forms (Firefox 67+ only) - disable CSS3 filter background ***************************/ /* @import "./css/webcontent/autofill_forms_background_white.css"; /**/ /************************************************************************************************/ /************************************************************************************************/ /* Create a new file "my_userContent.css" and add own/custom code to it. ************************/ /* @import "./my_userContent.css"; /**/ /************************************************************************************************/ /************************************************************************************************/ /************************************************************************************************/ ```
Aris-t2 commented 4 years ago

Will be fixed on next update. The "!important" is missing for those rules. It was not required in the past, but is now.

Pizzapops commented 4 years ago

I have added the fix to hide the report/manage buttons. Thanks!

A button for extensions that can't be deleted by the addon manager would be nice. Bitdefender adds a tracker extension and a wallet extension that show "Can't be removed Why?. 2019-10-18_091402 It does link to information page but when icons are used instead of text, it would nice to have a just question mark instead. 2019-10-18_091755

Just food for thought.

Aris-t2 commented 4 years ago

I don't have BitDefender installed, but something like this might work, if you find additional attributes so these rules only affect certain remove buttons:

panel-item[action="remove"][data-l10n-id="remove-addon-button"] slot[name="support-link"] {
  display: none !important;
}
panel-item[action="remove"][data-l10n-id="remove-addon-button"]:after {
  display: block !important;
  content: "?" !important;
  -moz-margin-start: -10px !important; /* adjust ? label*/
} 
Aris-t2 commented 4 years ago

Initial issue fixed in 2.7.7.