Aris-t2 / CustomCSSforFx

Custom CSS tweaks for Firefox
GNU General Public License v3.0
1.8k stars 181 forks source link

The unclickable buttons with “buttons_on_navbar_classic_appearance.css”, or “buttons_on_navbar_classic_appearance_v2.css” enabled are not greyed out #604

Closed Aleksandra0056 closed 11 months ago

Aleksandra0056 commented 1 year ago

1. Does the issue occur without any files inside /chrome/ folder?

2. Issue description, userChrome.css/userContent.css 'settings' the issue occurs with and steps to reproduce the issue:

Steps to reproduce:

  1. Apply the buttons_on_navbar_classic_appearance.css to userChrome.css,
  2. Install the Global Media Controller and add the button to Navigation Toolbar (navbar),
  3. As you see, the Global Media Controller button is not greyed out.

Expected results:

3. Does the issue occur with the most recent version of CustomCSSforFx (release/test/dev build)?

4. Screenshots showing the issue (drag & drop images into this post):

The Global Media Controller button should be normally greyed out, but actually it isn't (Image is zoomed):

Not greyed out button

NOTE: Maybe the screenshot doesn't actually look like the buttons_on_navbar_classic_appearance.css, but I have applied the square corners from Firefox UI Fix.

5. System information

Aris-t2 commented 1 year ago

Test https://github.com/Aris-t2/CustomCSSforFx/releases/tag/4.3.8test

Aleksandra0056 commented 1 year ago

Is this your first test pre-release?

Aleksandra0056 commented 1 year ago

Well, it is still affected in buttons_on_navbar_classic_appearance_v2.css

Aleksandra0056 commented 1 year ago

Wait, it is intentional, that aero buttons doesn't have idle (unclicked, and unhovered) state filled (Not empty, sorry for confusion)?

Aleksandra0056 commented 1 year ago

UPDATE 17:51 It is only partially affected, well, the greying out is not strong as in other toolbars, the icons are not greyed out correctly, are you willing to consider fixing it please? (Just ignore my third comment “Well, it is still affected in buttons_on_navbar_classic_appearance_v2.css”)

Aris-t2 commented 1 year ago

The opacity of disabled buttons was 0.6 for a long time. Not sure, if I set it years ago or it was like this in Firefox 4-28. Current Firefox files contain a value of 0.4. Use the new test file: https://github.com/Aris-t2/CustomCSSforFx/releases/tag/4.3.8test

Wait, it is intentional, that aero buttons doesn't have idle (unclicked, and unhovered) state filled (Not empty, sorry for confusion)?

Yes. Only a hovered/clicked/active state is present.

Aleksandra0056 commented 1 year ago

Yes. Only a hovered/clicked/active state is present.

But before this change, it was different.

Aris-t2 commented 1 year ago

Nope.

If you go back to v4.3.0 for example, it is the same: https://github.com/Aris-t2/CustomCSSforFx/blob/596428caeeb98d61bfd2ae47c870f4112e74a6eb/current/css/buttons/buttons_on_navbar_aero_appearance.css

Only v4.3.6 had this by mistake.

Aleksandra0056 commented 11 months ago

I'm closing this...