Aris-t2 / CustomCSSforFx

Custom CSS tweaks for Firefox
GNU General Public License v3.0
1.8k stars 181 forks source link

Firefox 121+ - close_icon_red.css, addonlists_colorized_button_icons.css, addonlists_replace_button_labels_with_icons.css + Feature Requests..! #644

Closed StavrosTsik closed 2 weeks ago

StavrosTsik commented 2 months ago

@Aris-t2

Hello. I'm opening an issue, because of some incompatibility (I think !? :confused:) of latest's CustomCSSforFx version, specific css's I noticed, with Firefox 121 to 124+.

In userChrome.css:

In userContent.css:

Feature Request.:

  1. Can the "Sync category and Page" be also hidden, using userContent.css ? Sync category and Page

  2. Using /css/tabs/_tabs_multiple_lines_force_newtab_button_visibility.css_, the "New Tab" button isn't centered dynamically as the rows increasing. Can be "fixed" like it was fixed in "NoiaButtons_v3.0.2" ? (I was also referring to this feature here) 307537133-206d2a33-a084-4d7b-b455-5c7d44a86481

System information

Aris-t2 commented 2 months ago
  1. I can add support for TMPs button ID for all "close icon" options like I did in NoiaButtons, but I can not test the results.
  2. CustomsCSSforFx used browsers default icons for addon managers buttons icons. You are meant to use addonlists_replace_button_labels_with_icons.css together with addonlists_show_buttons_instead_of_menu_popup.css. The dark icons, when using dark theme are a bug. It will be fixed on next update.
  3. Both "feature requests" will be part of next update.
StavrosTsik commented 1 month ago

Hello @Aris-t2. After testing the new release, here are my findings:

  • When using "/css/generalui/_close_icon_red.css"_ together with TabMixPlus (and the Multi-row option), the "Close Tab" button is becoming invisible...
  1. I can add support for TMPs button ID for all "close icon" options like I did in NoiaButtons, but I can not test the results.

Unfortunately the issue still persists. :cry::worried::disappointed:

2. CustomsCSSforFx used browsers default icons for addon managers buttons icons. You are meant to use addonlists_replace_button_labels_with_icons.css together with addonlists_show_buttons_instead_of_menu_popup.css. The dark icons, when using dark theme are a bug. It will be fixed on next update.

Resolved.!! :thumbsup::+1::relaxed:

3. Both "feature requests" will be part of next update.

From both requests, unfortunately the "Sync" category still remains visible. I enabled sync_category_always_hidden.css in userContent.css but does nothing.! :disappointed:

Tested all on Firefox version: 121 through 124.0.2

StavrosTsik commented 1 month ago

Hello @Aris-t2. I've tested the new v4.5.0 release and it's close to eliminate all issues:

  • When using "/css/generalui/_close_icon_red.css"_ together with TabMixPlus (and the Multi-row option), the "Close Tab" button is becoming invisible...
  1. I can add support for TMPs button ID for all "close icon" options like I did in NoiaButtons, but I can not test the results.

The issue still persists. :cry::worried::disappointed:

From both requests, unfortunately the "Sync" category still remains visible. I enabled sync_category_always_hidden.css in userContent.css but does nothing.!

Fixed.!! :thumbsup::+1::relaxed:

  • P.S: As a feature request, can "Add-ons Support" link in Add-ons page also be hidden ? It's useless and unnecessary..

Fixed at a 50% level. I enabled addons_support_always_hidden.css in userContent.css. When on "Extensions & Themes" page is hidden, as it should be but when on "Firefox Settings" page it's showing again:

"Extensions & Themes" page:

Extensions   Themes

"Firefox Settings" page:

Firefox Setting Page

Tested on Firefox version: 124.0.2

Aris-t2 commented 1 month ago

Run some tests with this build: chrome.zip

Addons support was hidden by the corresponding option. Browser settings require an own one.

(Not sure, but it might help to solve the close icon issue too.)

StavrosTsik commented 1 month ago

Run some tests with this build:

Happy to report:

Addons support was hidden by the corresponding option. Browser settings require an own one.

Fixed.!! (Add-ons Support link in Add-ons page 100% hidden) :thumbsup::+1::relaxed:

(Not sure, but it might help to solve the close icon issue too.)

Finally this test build fixed the issue.!! :thumbsup::+1::relaxed: Close Tab

Safe to say the reported isuses as FIXED.!!

Thanks a lot @Aris-t2 👍 👍

P.S Should I wait for an "official v4.5.1" release ???

Aris-t2 commented 1 month ago

No need to wait, you can use the files as they are.

StavrosTsik commented 1 month ago

Hi @Aris-t2 One last question. Could you tell me how to make the size of "Close Tab" button of the above picture (arrow showing), a little bit bigger but does not affect the close button on tabs ?

Thanks..

Aris-t2 commented 1 month ago

Maybe one of these code snippets three can help you:

#tabmix-tabs-closebutton .toolbarbutton-icon {
    width: 24px !important;
    height: 24px !important;
    padding: 0 !important;
}
#TabsToolbar-customization-target *:not(#tabbrowser-tabs) .toolbarbutton-icon {
    width: 24px !important;
    height: 24px !important;
    padding: 0 !important;
}
#TabsToolbar-customization-target *:not(#tabbrowser-tabs) .close-icon {
    width: 24px !important;
    height: 24px !important;
    padding: 0 !important;
}
StavrosTsik commented 1 month ago

Thanks for the provided snippets. Should I add one of them in my userChrome.css or that code already exists somewhere in the project’s various css’s ? (I don’t want any conflict)

Aris-t2 commented 2 weeks ago

my_userChrome.css is the best location for custom stuff.