Aris-t2 / CustomCSSforFx

Custom CSS tweaks for Firefox
GNU General Public License v3.0
1.87k stars 181 forks source link

Can't get the titlebar to display the title [as in "New Tab-Firefox"]. #645

Closed clifford269 closed 4 months ago

clifford269 commented 7 months ago

Firefox 115. Windows 7 x64 with Classic theme. It does appear while the window is being maximised, though. The in-private window retains black background. Capture

Aris-t2 commented 7 months ago

Which version of "CustomCSSforFx" are you using?

This CSS-feature was removed a long time ago, because it failed to work with recent Firefox versions back then.

The JS replacement should still work: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/tab_label_in_titlebar.uc.js

clifford269 commented 7 months ago

Which version of "CustomCSSforFx" are you using?

Your Feb-10 release version.

This CSS-feature was removed a long time ago, because it failed to work with recent Firefox versions back then.

I wasn't aware of this. That should work. Thanks! Edit: The browser doesn't apparently load any of the scripts . Here is my userChrome.js

image

image

Aris-t2 commented 6 months ago

JSs scripts work up to the latest Nightly build. image

Your issue might not be related to custom scripts or styles at all. The screenshot shows default OS titlebar, right? (The one you enable in customizing mode.) image

If JS scripts refuse to work, try to setup CustomJSforFx again. Don't forget to clear startup cache: https://github.com/Aris-t2/CustomJSforFx?tab=readme-ov-file#scriptstartup-cache-must-be-deleted-after-every-change

clifford269 commented 6 months ago

JSs scripts work up to the latest Nightly build. image

Your issue might not be related to custom scripts or styles at all. The screenshot shows default OS titlebar, right? (The one you enable in customizing mode.) image

If JS scripts refuse to work, try to setup CustomJSforFx again. Don't forget to clear startup cache: https://github.com/Aris-t2/CustomJSforFx?tab=readme-ov-file#scriptstartup-cache-must-be-deleted-after-every-change

Ah, that was already a mozilla thing. Got applied instantly. Can't believe they keep making software dumber. But JS didn't work. I kept clearing startupcache and did right with those files.

clifford269 commented 6 months ago

Capture

Capture2

Now this is just beautiful. You can upstream the code for this new tab page I did, if you want.

clifford269 commented 6 months ago

Can you get sites to be pinned somewhere on the toolbar, just like apps on taskbar?

Aris-t2 commented 6 months ago

Firefox does not offer the possibility to move bookmarks out of the "bookmarks item" image

You can modify https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/about_button_generic.uc.js script and force it to load a page you want. Therefore you would have to create an own button for every page you want to move to your toolbar.

// text

(function() {

try {

  Components.utils.import("resource:///modules/CustomizableUI.jsm");
  ChromeUtils.importESModule("resource:///modules/CustomizableUI.sys.mjs");
  const sss = Components.classes["@mozilla.org/content/style-sheet-service;1"].getService(Components.interfaces.nsIStyleSheetService);

  const button_label = "About Button (generic)"; // add label here

  CustomizableUI.createWidget({
    id: "button_to_url_XYZ", // button id
    defaultArea: CustomizableUI.AREA_NAVBAR,
    removable: true,
    label: button_label, // button title
    tooltiptext: button_label, // tooltip title
    onClick: function(event) {

      const win = Components.classes["@mozilla.org/appshell/window-mediator;1"]
        .getService(Components.interfaces.nsIWindowMediator)
        .getMostRecentWindow("navigator:browser");

      if(event.button=='0') {
        try {

            win.gBrowser.selectedTab = win.gBrowser.addTrustedTab('https://www.google.com'); // add own url here

        } catch (e) {}
      }   
    },
    onCreated: function(button) {
      return button;
    }

  });

  // style button icon
  const uri = Services.io.newURI("data:text/css;charset=utf-8," + encodeURIComponent('\
    \
      #about-button-gen .toolbarbutton-icon {\
        list-style-image: url("chrome://global/skin/icons/defaultFavicon.svg"); /* icon / path to icon */ \
        fill: dimgray; /* icon color name/code */\
      }\
    \
  '), null, null);

  sss.loadAndRegisterSheet(uri, sss.AGENT_SHEET);

} catch (e) {
    Components.utils.reportError(e);
};

})();
clifford269 commented 6 months ago

Right. So much for being a "corporation".