[MULTIPLE BOOKMARK LINES SUPPORT THREAD]

[ao2]

1. Describe the issue

I have lots of bookmarks in the bookmark toolbar section, but only a part of them are shown in the toolbar when enabling bookmarks_toolbar_multiple_lines.css

I checked that either scrolling down to the bottom, or setting:

  --bookmark_items_height: 999px; /* <- bookmark items - line height */
  --bookmark_items_lines: 1; /* <- maximum amount of lines */

only a certain number of bookmarks are shown (95 in my case), not all of them.

2. What should have happened instead?

I would have expected to be able to access all bookmarks in the toolbar after scrolling down to the bottom.

3. Steps to reproduce the issue?

Just enable bookmarks_toolbar_multiple_lines.css and add a lot of bookmarks to the bookmarks toolbar, after a certain point new bookmarks are not shown anymore in the toolbar. They can still be accessed in the bookmarks menu.

5. System information

• OS & OS version: Linux/Debian
• Firefox version: 57.0.3
• Firefox theme / lw-theme: default theme
• This projects settings the issue occurs with: bookmarks_toolbar_multiple_lines.css

Thanks, Antonio

[Aris-t2]

There might be an internal limit for the maximum amount of visible bookmarks inside "bookmarks item box". This limit does not affect popup menus.

In my tests 110 of 250 bookmarks are visible (on Win7 with Fx59) and it does not matter how many visible lines I set 2, 10 or 20.

After all this is an experimental feature offering something not meant to be available by default. I will add a note to userChrome.css about this unless this can be resolved somehow.

[ao2]

There might be an internal limit for the maximum amount of visible bookmarks inside "bookmarks item box". This limit does not affect popup menus.

I tried the same userChrome.css in FF55 and the limitation is not there, all bookmarks are visible by scrolling down the toolbar. I'll do some more research and maybe post a bug report to Firefox itself.

[Aris-t2]

In my tests Firefox 52-56 was also free of that limitation. Must be something they introduced in Fx57.

[ao2]

For now I mentioned the problem in https://bugzilla.mozilla.org/show_bug.cgi?id=1420089

[ao2]

The limit on number of items in the bookmarks toolbar has been introduced by https://hg.mozilla.org/mozilla-central/rev/b3a7b5c0618b to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1392081

[Aris-t2]

So there is nothing we can do about. There is no hidden preference to workaround this.

[shogunreaper]

i just started trying to use css and i can't get this one to work

no matter what i change

--bookmark_items_lines: 2;

to the number of lines stays at 3.

is there something else i need to edit?

[Aris-t2]

If you are using the complete release archive of this project, you have to change variables inside \config\general_variables.css.

The variable has also to be inside the actual CSS file for users, that only pick some files of this project without using the whole package.

[shogunreaper]

thanks that worked

is there a way to increase the width of the area used? There's a ton of unused space on the right side near the scrollbar.

[Aris-t2]

Post a screenshot.

This "problem" may be based on the length of your bookmarks and you window width.

You get different results depending on your window width. Look here:

[shogunreaper]

https://i.imgur.com/UaPiCpx.png

looks like it depends on the name of the previous bookmarks, if it's short then it will have a lot of unused space.

[Marcosdw]

/* @import "./css/toolbars/bookmarks_toolbar_multiple_lines.css"; /*/ / <--- EXPERIMENTAL */

does not work on the latest version Nightly 66 __ Sorry I use an online translator French / English

[Aris-t2]

Thanks for letting us know. (Multiple tab lines v1 also refuses to work on current Nightly builds.)

[Speravir]

Oh, this is mean what a coincedence: I had the idea to test whether a flex or grid layout would help for multiple lines in Fx66, and therefore downloaded a beta version, but faced some other problems more important in the moment to me, so testing didn’t start yet. Now, you come with the same idea, and one advantage of it is I could test the rule: It works great, thank you!

[Marcosdw]

Hello,

I test in Fx66b9 : @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx66.css"; Work fine but please add scrollbar as in older versions because truncated with 3 lines Thanks __ Sorry I use an online translator French / English

[Aris-t2]

This was already fixed by Achille. It will be on next update.

[Marcosdw]

Ok thank you ;)

[ArkadiuszMichalski]

Hello, I have really strange behaviour when use; @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx66.css";

I use last Nightly 68.a01 and only custom CSS from here (without any addons).

Actually set that options in general_variables.css:

/* for bookmarks_toolbar_multiple_lines.css */
  --bookmark_items_height: 26px !important; /* <- bookmark items - line height */
  --bookmark_items_lines: 3 !important; /* <- maximum amount of lines */

and personal setting in my_userChrome.css:

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item{
  margin-top: 0px !important;
  margin-bottom: 0px !important;
  padding-right: 2px !important;
}

My bookmarks toolbar has 3 line of bookmark. Last line its not full, just half. Problem is when I try opening some url then all items on bookmarks toolbar disappears for short time and then appears. Time from disappears to appears is different (1s or less), and basically I do not know what it depends on (maybe after load URL all items back). Look for that picture:

It's strange because happend not for every URL, but for some of them (and not every time:). And loading this url from bookmark toolbar or URL bar make the same blinking result.

I remember that in past I have the same problem when using Multirow Bookmarks Toolbar Plus extension in new FX version, so I jump to Roomy Bookmarks Toolbar extension and problem dissapears. Has anyone met such behavior and knows how to fix this flashing?

@Aris-t2 any solution? Eventually I will try to import the code from Roomy Bookmarks Toolbar to my uc.js script, but I would prefer a solution in pure CSS (if it's possible).

[Aris-t2]

Haven't seen this glitch here yet.

[ArkadiuszMichalski]

I have this since FX54 or even earlier. It is possible that my set of bookmarks has such a strange behavior, I will try to reproduce it on a clean profile with minimal changes and few tabs (but minimum 2 line). If you would be interested, I would send a link to such a profile, because without it you will never fix it.

Edit1: they don't disappear when I have scroll in bookmarks toolbar (to many bookmarks for 3 line).

Edit2: problem appear when I add some new bookmark to existing bookmark folder. When I restart browser then problem not appear, but still when add next new bookmark to existing folder problem appear until next restart browser.

[Aris-t2]

Sure, share a link with a new test profile uploaded to a share service like Dropbox ( or similar without waiting times, capchas or registrations ;-) ).

Setup Portable Firefox, add the latest files of the project to /chrome/ folder and setup theme, create a bunch of bookmarks..., zip/rar/7z the /profile/ folder and upload it somewhere.

[Pastant]

1. Describe the issue

I have lots of bookmarks in the bookmark toolbar section, but the third row is not completely visible when enabling bookmarks_toolbar_multiple_lines.css:

--bookmark_items_height: 35px; / <- bookmark items - line height / --bookmark_items_lines: 4; / <- maximum amount of lines /

doesn't seem to help.

2. What should have happened instead?

Show all three rows without scrolling.

3. Steps to reproduce the issue?

Just enable bookmarks_toolbar_multiple_lines.css and add a lot of bookmarks to the bookmarks toolbar. The third row will not show completely. And multiple tab bars is not compatible with this tweak: ./css/tabs/tabs_multiple_lines_v3.css

5. System information

OS & OS version: Win 7 64 bit
Firefox version: 68.0.1
Firefox theme / lw-theme: default theme

Thanks

[Aris-t2]

As far as I know the combination 'tabs not on top' + 'tabs multiple lines' + 'multiple bookmarks lines' never worked properly.

As a workaround you can try 'tabs_below_navigation_toolbar_fx65_v2.css' + 'tabs_multiple_lines_v3.css' + 'bookmarks_toolbar_multiple_lines_fx66.css'.

[Pastant]

Thanks for the response. The workaround works almost perfect ...

The combination 'tabs not on top' + 'tabs multiple lines' + 'multiple bookmarks lines' worked with FF ESR 60.0.8 properly:

[Aris-t2]

I meant it stopped working perfectly after Mozillas tab changes in Fx65.

[ArkadiuszMichalski]

@Aris-t2 This not work in last Nightly 74 (all bookmarks folder display vertically - one by one). Can anyone confirm this bug?

[Aris-t2]

I can confirm it.

Since it was not my code, we have to wait for a workaround from the original author.

[topiland]

@Aris-t2 sems now tabs width interfere bookmarks toolbar width --tab_max_width: 2000px !important; in config fixed bookmark tolbar width Still was 200 even the --bookmark_items_lines: 10 worked with one bookmark /line

[topiland]

This is what mostly working for me with ff74:

/* Firefox Quantum userChrome.css tweaks ************************************************/
/* Github: https://github.com/aris-t2/customcssforfx ************************************/
/****************************************************************************************/

/* NOTE  ********************************************************************************/
/* Variables are set inside '.\config\' folders CSS files, if complete package is used! */

/* import old button/bookmark size code *************************************************/
@import "./../buttons/buttons_on_bookmarks_toolbar_old_size_and_appearance.css";

:root {
  --bookmark_items_height: 26px; /* <- bookmark items - line height */
  --bookmark_items_lines: 3; /* <- maximum amount of lines */
}

#PersonalToolbar {
      min-height: var(--bookmark_items_height) !important;
      max-height: calc(var(--bookmark_items_height)*(var(--bookmark_items_lines))) !important;
    }

    #personal-bookmarks,
    #PlacesToolbar > hbox {
        display: block;
    }

    #PlacesToolbarItems {
        display: flex;
        flex-wrap: wrap;
        overflow-x: visible;
        overflow-y: auto;
    }

#PlacesToolbarItems > .scrollbox-innerbox {
  display: flex;
  flex-wrap: wrap; 
  overflow-x: hidden !important;
  overflow-y: visible !important;
  max-height: calc(var(--bookmark_items_height)*(var(--bookmark_items_lines))) !important
}

#personal-bookmarks #PlacesToolbar {
  display: block;
  min-height: 0;
  overflow-x: hidden;
  overflow-y: auto;
  max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) );
}

#personal-bookmarks #PlacesToolbar > hbox > hbox{
  overflow-x: hidden;
  overflow-y: hidden;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator[collapsed="true"],
#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator{
  display: none;
}

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item{
  padding-top: 0px !important;
  padding-bottom: 0px !important;
  margin-top: 2px !important;
  margin-bottom: 2px !important;
  vertical-align: middle;
}
/*
#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item:hover:active:not([disabled="true"]),
#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item[open="true"] {
  padding-top: 2px !important;
  padding-bottom: 2px !important;
}
*/
#personal-bookmarks #PlacesToolbar toolbarseparator{
  -moz-appearance: none !important;
  visibility: visible !important;
  display: inline;
  text-shadow: none !important;
  border-left: 3px solid ThreeDShadow !important;
  border-right: 3px solid ThreeDHighlight !important;
  vertical-align: middle;
}

#personal-bookmarks toolbarbutton.bookmark-item[dragover][open]{
  -moz-appearance: toolbarbutton;
}

#navigator-toolbox #PersonalToolbar { 
  max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) ) !important;
}

[Aris-t2]

Thanks for the new code. I will add it on next update.

[tramp20]

@Aris-t2 Thank you for your updates. Since Fx 74 beta 3 (and with custom_css_for_fx_v3.0.2_v3) I see only one bookmarks toolbar instead of two. The newest 74 beta5 shows the same behavior. Sorry I am not able to understand the CSS code :-(

[Aris-t2]

There are three settings inside userChrome.css

/* @import "./css/toolbars/bookmarks_toolbar_multiple_lines.css"; /**/ /* <--- EXPERIMENTAL */
/* @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx66.css"; /**/ /* <--- EXPERIMENTAL */ /*Fx66-73*/
/* @import "./css/toolbars/bookmarks_toolbar_multiple_lines_fx74.css"; /**/ /* <--- EXPERIMENTAL */ /*Fx74+*/

Are you using the correct one?

[tramp20]

The last one of course, the first two betas of Firefox were ok with css v3.02.

[Aris-t2]

bookmarks_toolbar_multiple_lines_fx74.css works here on Fx 73, 74 and 75. Maybe you are using a combination of settings, that does not support multiple bookmarks lines or maybe you are talking about something else, because your are referring to "bookmark toolbars" and not lines/rows of bookmarks.

Post screeshots of how your config looks and how it should look.

[Aris-t2]

Using addonbar_extra_bookmarks_toolbar_below_navbar_fx65.css and moving bookmarks to navigation toolbar offers this result:

Using bookmarks_toolbar_multiple_lines_fx74.css and keeping bookmarks on bookmarks toolbar offers this result:

You can not combine both settings, it will not work.

[tramp20]

Thank you but I could not solve my problem :-( So I did a new fresh Fx 74.0b5 installation and now all is ok again.

[tramp20]

Sorry but after updating Fx 74.0b3 to Fx 74.0b5 the error comes back.

Firefox 74.0b3:

Firefox 74.0b5:

I am using custom_css_for_fx_v3.0.3 and I did not change anything between the update. It is reproducible (already 3 times).

[Aris-t2]

Not sure what to say, tabs_below_navigation_toolbar_fx72.css + bookmarks_toolbar_multiple_lines_fx74.css works fine here.

[tramp20]

works fine here.

I found (hopefully) the culprit: Since some years I imported a my_userchrome.css (from MZine forum). This file is ofc outdated (I do not understand what it should do 2 or 3 years ago but it helped). But now with the latest Fx 74 it prevents the latest custom_css from correct working.

my_userChrome.zip

[Aris-t2]

Your file was an older version of a multiple bookmarks lines script. It broke the "current" one. Just remove it.

[tramp20]

Thank you very much :-)

[netgrafik]

Where to add the file "userChrome.css" in the portable Firefox version?

Firefox Developer 74.0b9 Portable version from the website in : http://portableappz.blogspot.com/2012/07/mozilla-firefox-150-beta-2-multilingual.html

Thanks

[Aris-t2]

FirefoxPortable\Data\profile\chrome

[c-stoyanov]

Hey guys, any idea how to fix the bookmarks to not show one under the other? (I'm using FF 74.0). Thanks.

[Aris-t2]

Use the most recent files of this project. "bookmarks_toolbar_multiple_lines_fx74.css"

[Thomas000101]

I use the file that came with the 3.03V2 Pack and it only gave me 2 lines on FF 74 with the scrolling bar I don`t want :( I tried to edit the .css file and wrote "6", but it doesnt work. (bookmark_items_lines: 6) Is there a newer working version? If yes, can you give us the Link please?

-Edit-

I edit the "general_variables.css" file and set it on "6" now and it seems to work.... But only for 3 lines. on the 4th line it shows a grey line and doesnt fit the used Theme :(

[Aris-t2]

I can't do anything about the the used theme. Theme devs mostly provide images for about 3-4 top toolbar lines only, because the default ui does not extend that much.

[Thomas000101]

ok, thank you anyway for your great work :)

[c-stoyanov]

Thanks very much for the feedback, I've managed to get the desired result, but now I'm getting a huge black bar below the tabs bar? Any ideas?

[Aris-t2]

Nope, never saw this one.