Aris-t2 / CustomJSforFx

custom scripts
GNU General Public License v3.0
236 stars 22 forks source link

[Fx123] Search_engine_icon_in_searchbar - stopped working #108

Closed Acid-Crash closed 1 month ago

Acid-Crash commented 6 months ago

Describe the issue: After update to Firefox 123 search icon reversed to standard glass icon (module stopped working). Reinstalling, clearing startup cache does not help

What should have happened instead? Module should replace icon of the search bar

Steps to reproduce the issue? Activate Search_engine_icon_in_searchbar. Observe the result

Screenshots (drag and drop images into this post): зображення

зображення

System information OS & OS version: Win 10 x64 Firefox or Thunderbird: Firefox Firefox/Thunderbird version: Firefox 123 Firefox/Thunderbird theme: default

Speravir commented 6 months ago

Oh, may this be related to the issue that the alternative searchbar script is not loaded anymore, too? Confer reports from @maryadavies and @CP1832 three days ago in discussions.

Maybe, it’s the same reason?

maryadavies commented 6 months ago

Oh, may this be related to the issue that the alternative searchbar script is not loaded anymore, too? Confer reports from @maryadavies and @CP1832 three days ago in discussions.

Maybe, it’s the same reason?

It may be. I'd appreciate a fix other than redo Firefox bleeeh!

Aris-t2 commented 6 months ago

The issue is caused by the gone/deprecated call document.getElementById("searchbar").currentEngine.iconURI.spec.

I'm currently looking for the new way to get the icon.

Aris-t2 commented 6 months ago

document.getElementById("searchbar").currentEngine.getIconURL() should work as a replacement.

Aris-t2 commented 6 months ago

Get the updated file.

Speravir commented 6 months ago

Aside from that I am do not using this script (but the other one mentioned above), let me once again thank you for your work!

Acid-Crash commented 6 months ago

Hi all. Reporting back. The updated script does work as expected both on FF 123 and Nightly 125

UPD found another bug, please see the latter comment зображення

Acid-Crash commented 6 months ago

UPD. Found another bug. For some reason when I activate Picture in Picture mode (In example this is Youtube) the icon becomes invisible.

icon

You need to fully reload browser to restore it.

Aris-t2 commented 6 months ago

Test the latest file.

The new file is based on 'alternative_searchbar.uc.js' with everything removed except the search icon part.

Acid-Crash commented 6 months ago

@Aris-t2 The issue with the Picture in Picture mode is fixed now. I will continue my observation for some time.