search

Aris-t2 / CustomJSforFx

custom scripts
GNU General Public License v3.0
239 stars 22 forks source link

Additional toolbars labels have unnecessary "(NULL)" suffix #112

Closed Aleksandra0056 closed 3 months ago

Aleksandra0056 commented 3 months ago

Issue description:

The additional toolbars have the redundant suffix "(NULL)" in their names in the panel right-click context menu which also clutters the names.

What should have happened instead?

The additional toolbars should have clear names without the suffix "(NULL)".

So, my solution is to fix it and remove the suffix "(NULL)" from their names.

Steps to reproduce:

IMPORTANT: Make sure you have enabled the additional_top_toolbars.uc.js script before trying to reproduce the steps.

  1. Open Firefox,
  2. Right-click on navigation bar,
  3. You see additional toolbar labels.

Screenshots:

Null label on additional toolbars

Additional attachments:

My additional_top_toolbars.uc.js script file: additional_top_toolbars.uc.js.txt

System informations:

OS & OS version: Windows 10 22H2 19045.4529 (64-bit) Firefox or Thunderbird: Mozilla Firefox (64-bit) Firefox/Thunderbird version: v127.0.2 Firefox/Thunderbird theme: Firefox UI Fix and Activist – Soft Scripts loader: Firefox Scripts (unofficial version by Onemen)

Aris-t2 commented 3 months ago

Get the updated file.

Fx requires an acceleration key to be set in the code since version 127 (or earlier too?). In this case additional toolbars do not need any, so adding toptoolbar.setAttribute("accesskey",""); fixes the issue.

Aleksandra0056 commented 3 months ago

Okay, thanks! The issue has now completely disappeared.