Aris-t2 / CustomJSforFx

custom scripts
GNU General Public License v3.0
239 stars 22 forks source link

Vertical Add-on Bar can contain items with non-standard widths #114

Closed Aleksandra0056 closed 2 months ago

Aleksandra0056 commented 2 months ago

Describe the issue:

What should have happened instead?

Steps to reproduce the issue?

Do this:

  1. Open Firefox,
  2. Put Search Bar, Edit Controls to Vertical Add-on Bar,
  3. Put also Profiler if you use Firefox Developer Edition,
  4. Now save and edit Customise Firefox mode,
  5. You will see the issue.

Screenshots:

Screenshot from Customise Firefox:

Vertical addon bar can contain items with non-standard width

Screenshot depicting the issue:

But they aren't usable due to unsupported width

System information:

OS & OS version: Windows 10 22H2 19045.4717 Firefox or Thunderbird: Firefox Firefox/Thunderbird version: 128.0.3 Firefox/Thunderbird theme: Firefox UI Fix (https://github.com/black7375/Firefox-UI-Fix)

Aris-t2 commented 2 months ago

Test the new file: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar_vertical.uc.js

Aleksandra0056 commented 2 months ago

Test the new file: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar_vertical.uc.js

It looks good.

Aleksandra0056 commented 2 months ago

Moment, the profiler arrow isn't correctly aligned and has a missing icon, so it's still unresolved.

Look:

https://github.com/user-attachments/assets/5a1de5a0-c8fc-4776-8239-b113ef8618af

Aris-t2 commented 2 months ago

Test the new file: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar_vertical.uc.js

Aleksandra0056 commented 2 months ago

Test the new file: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar_vertical.uc.js

It looks better, but the arrow button in Profiler is full-size, so can you make it slim as it behaves on the other toolbars?

image

Aleksandra0056 commented 2 months ago

Also, separators between Edit Controls should normally appear, but in the Vertical Add-on Bar they are missing.

Toolbars: Screenshot 2024-08-05 194443

Vertical Add-on Bar: Screenshot 2024-08-05 194512

Aleksandra0056 commented 2 months ago

The right-click context menu on the Search Bar also appears completely broken (like if it was flipped): Screenshot 2024-08-05 194745

Aris-t2 commented 2 months ago

Separators get removed on purpose.

Searchbar was not meant to be used like this. I just moved it a bit, so it won't disappear once placed there. It is more or less just for fun and not for productive usage.

Aris-t2 commented 2 months ago

You can the the new file, but now all of the content seen on your screenshot will be displayed there correctly.

Aleksandra0056 commented 2 months ago

No, Profiler still has the drop-down arrow shaped incorrectly: image

And icons in the context menu in the search bar are still glitched: image

Aleksandra0056 commented 2 months ago

This is how the drop-down arrow should be shaped on vertical add-on bar: Screenshot 2024-08-06 202636

I edited this image through Paint.net, so it wasn't screenshotted on the actual Firefox.

Aris-t2 commented 2 months ago

The icons inside that menu are not part of Firefox and won't be fixed as stated before. See "You can the the new file, but now all of the content seen on your screenshot will be displayed there correctly."

Profilers dropmarker is internally a default toolbarbutton and won't be changed.

Aleksandra0056 commented 2 months ago

Fine, but at least you could remove the rotation of the search bar right-click context menu.

And you can't re-shape the profiler drop-down arrow button because it isn't possible or because you don't want to?

Aris-t2 commented 2 months ago

Why do we have to change the rotation? Default browser configuration looks like this: image

Anyways, nobody uses search bar like this, its just for fun.

Profilers dropmarker height can be changed. I posted a new file.

Aleksandra0056 commented 2 months ago

Why do we have to change the rotation? Default browser configuration looks like this: image

Anyways, nobody uses search bar like this, its just for fun.

Profilers dropmarker height can be changed. I posted a new file.

Okay. I agree with the solutions of the profiler dropdown button and the search context menu.

I think, that we can close this issue.

But one weird thing happened when I replaced the "addonbar_vertical.uc.js", because after Firefox restarted, the search bar disappeared, so I had to remove the "addonbar_vertical.uc.js" file from the chrome folder, restart Firefox, relocate the search bar to another toolbar and re-add the file to chrome folder, but now the search bar didn't disappear and everything works fine.

Aleksandra0056 commented 2 months ago

Moment, the search bar disappears from the Vertical Add-on Bar after every restart, so it isn't solved.

Aris-t2 commented 2 months ago

Your might want to clear your startup cache. Search bar stays in my tests on Fx 128+.

Aris-t2 commented 2 months ago

https://github.com/user-attachments/assets/3a9f4a28-4593-47c2-bf48-5bc299050f23

Aleksandra0056 commented 2 months ago

Weird. Maybe it's a problem with my Firefox installation itself. So, I think, that it can be closed.