Aris-t2 / CustomJSforFx

custom scripts
GNU General Public License v3.0
238 stars 22 forks source link

[WebExtension window] Blank page with multiple toolbar scripts active (e.g. add-on bar & vertical add-on bar) #14

Closed GoogleBeEvil closed 5 years ago

GoogleBeEvil commented 5 years ago

open ublock original logger will open a blank window

Aris-t2 commented 5 years ago

Add-on windows are not officially supported by these scripts.

There is however a workaround by aborix which I added to my toolbar scripts. If you are using more, than one toolbar script, you have to remove the script addition from one file, e.g. from here (lines 65-74): https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar.uc.js#L65

GoogleBeEvil commented 5 years ago

works

GoogleBeEvil commented 5 years ago

there is still some issue."more than one scripts" will break some mini window(which usually do not have menubar,just a urlbar and close button,sorry do not know how to descript it) https://addons.mozilla.org/en-US/firefox/addon/popup-tool/ https://www.youtube.com/watch?v=Bey4XXJAqS8

and a gif show a mini window opened by js not addon-window https://imgur.com/a/VKxx2li the two mini window one is blank ,one is normal

Aris-t2 commented 5 years ago

Sorry, but there is nothing we can do about mini windows right now. You could only try to increase the timing to 1500 or more for example and see what happens: https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/addonbar_vertical.uc.js#L223

GoogleBeEvil commented 5 years ago

doesnt work.still make mini window blank.hope mozilla dev toolbar api soon

GoogleBeEvil commented 5 years ago

http://tieba.baidu.com/p/6045112678 a modify by @黒仪大螃蟹 that fix https://github.com/Aris-t2/CustomJSforFx/issues/14#issuecomment-465918566

insert if (window.__SSi && window.__SSi !== 'window0') { return gBrowser.selectedBrowser.removeAttribute('blank');}

after

init: function() {

to both uc.js files @Aris-t2

Aris-t2 commented 5 years ago

Thanks, I tested this and and it works for me. Posted new files.

GoogleBeEvil commented 5 years ago

edit:https://github.com/Aris-t2/CustomJSforFx/issues/14#issuecomment-466639766 wont work in the new window created by dragging tab, it require to set browser.link.open_newwindow.restriction to 0 fixing this ,or just using if (document.getElementById('main-window').getAttribute('chromehidden')) { return gBrowser.selectedBrowser.removeAttribute('blank');} instead https://github.com/Aris-t2/CustomJSforFx/issues/14#issuecomment-466639766.

Aris-t2 commented 5 years ago

So the script works fine now even without the old workaround.

GoogleBeEvil commented 5 years ago

emm,still an issue: this time is the addonbar.uc.js only. If u click link from third software and call firefox start up,the page is blank.can u check the code, i noticed the home page will flickering and scaled at the first time start.

but the vertical wont have this issue

Aris-t2 commented 5 years ago

Looks like the link opens a window where "chromehidden" is empty (or at least different from the other WebExtension windows), but the code only triggers, if "chromehidden" attribute is not empty.

Can't tell you why the same code works in one script, but not inside an other script.

GoogleBeEvil commented 5 years ago

[WebExtension window] Blank page with add-on bar script active. addonbar_v wont cause blank. test the old version of addonbar, the same ,so probably not cause by the https://github.com/Aris-t2/CustomJSforFx/issues/14#issuecomment-466959012 code

edit:but verticalbar cause stylush mini window blank....

GoogleBeEvil commented 5 years ago

https://github.com/xiaoxiaoflood/firefox-scripts/blob/master/chrome/status-bar.uc.js here is script that no mini blank、 no rescale home page.but it is useable only by the author's userchrome.js ,maybe load some libs add by the author can u port it to ordanay universal version load by ardiman or Endor8's userchrome.js version

Aris-t2 commented 5 years ago

You should be able too scripts from this collection to the method xiaociaoflood offers, since I can not reproduce most of the mentioned issues.

I also added xiaociaofloods method as "M3" to this project and mixed it with "M1", in case it works better or differently.

krystian3w commented 5 years ago

Workanoud no good works with Stylus - I lost url when create new stylesheet.

Aris-t2 commented 5 years ago

Test the updated toolbar scripts. Blank page on with new "normal/private" windows should be gone now too. The issue with WebExtension scripts was gone for a while now.

Aris-t2 commented 5 years ago

Continue here: https://github.com/Aris-t2/CustomJSforFx/issues/18