about_button.uc.js has no icon, no image

mimteatr commented 3 years ago

Lets keep issue area clean and ask questions within the general discussion thread: https://github.com/Aris-t2/CustomJSforFx/issues/29 (Firefox) https://github.com/Aris-t2/CustomJSforFx/issues/30 (Thunderbird)

Describe the issue: about_button.uc.js has no icon, no image! On the image below, button is placed between the restart_button on lef, (on red), and the minMaxCloseButton on the right at the corner but as you can see, actually you CAN'T see the button, but it is there!

What should have happened instead? Have an image icon???

Steps to reproduce the issue? Script loaded on FF

Method used (M1, M2 or M3): M2

Screenshots (drag and drop images into this post):

System information OS & OS version: Windows 10 Home 21H1 building 19043.1237 OS theme: Microsoft Windows "Life in Lavender" DPI / HiDPI resolution: 1920 X 1080, 150% scaling Firefox or Thunderbird: Firefox Firefox/Thunderbird version: 93.0b7 (64-bit) Firefox/Thunderbird theme: OceanReddit Settings this issue occurs with: Always

Aris-t2 commented 3 years ago

Do you have an up-to-date file?

The icon is present here even on Fx 94 for me.

Does the icon show up, if you paste this into location bar chrome://global/skin/icons/defaultFavicon.svg ?

mimteatr commented 3 years ago

Took it from here, isn't it the ONLY one available? https://github.com/Aris-t2/CustomJSforFx/blob/master/scripts/about_button.uc.js

The icon do show up on chrome://global/skin/icons/defaultFavicon.svg, strange!

Aris-t2 commented 3 years ago

There are two files, about_button_generic.uc.js and about_button.uc.js, but both point to chrome://global/skin/icons/defaultFavicon.svg.

Try to redownload the file and to clear the start-up cache.

mimteatr commented 3 years ago

Done and redone it all several times, no change.

The about_button_generic.uc.js shows the icon but the about_button.uc.js doesn't.

mimteatr commented 3 years ago

Hi!

I discovered that the following lines aren't on "about_button_generic.uc.js" but exist on "about_button.uc.js" so I've removed them and now the icon shows! 🎉🙏🥰

 var abouticon = "";
  if(appversion < 87) {
abouticon = "\
      #about-button .toolbarbutton-icon {\
        list-style-image: url("chrome://mozapps/skin/places/defaultFavicon.svg"); /* icon / path to icon */ \
      }\
      ';
  }

Aris-t2 commented 3 years ago

Alright, I will remove those lines from the file, but unless you don't mask your Firefox version as Firefox 86 or older, the code should not do anything.

mimteatr commented 3 years ago

What do you mean?

Aris-t2 commented 3 years ago

You wrote the icon appeared after removing the mentioned lines of code.

They get ignored on Firefox 88+ anyways, so I'm wondering how this issue even occurred, if you use a recent Fx version. There are some ways to mask your clients version. As a result the wrong icon path would be used.

The most recent version of the file I uploaded today, does not target older Firefox versions anymore and is Fx 88+ only.

mimteatr commented 3 years ago

I understand. I'm on FF beta and after today's update, strangely, it doesn't appear anymore, not even without icon!

Maybe I placed it on a different toolbar inadvertently but entering in "customize tollbar" it doesn't show it anywhere. Where is it supposed to show by default? Maybe I'm not seeing well!

mimteatr commented 3 years ago

UPDATE: I've downloaded your updated script from yesterday and not it works wonderfully!

Thanks, closing the issue 👌🙏👍

Aris-t2 / CustomJSforFx

about_button.uc.js has no icon, no image #48