Aris-t2 / CustomJSforFx

custom scripts
GNU General Public License v3.0
236 stars 22 forks source link

[BUG] tabstoolbar_below_navigation_toolbar.uc.js + notification box placement. #69

Open Sneakpeakcss opened 2 years ago

Sneakpeakcss commented 2 years ago

Describe the issue: tabstoolbar_below_navigation_toolbar.uc.js places tabs under navbar correctly, but after some update between ESR78-ESR91 #tab-notification-deck is placed between the two.

What should have happened instead?

tab-notification-deck should be placed below TabsToolbar

Steps to reproduce the issue? Force firefox to show a notification.

Method used (M1, M2 or M3): M2

Screenshots (drag and drop images into this post):

notificationbox

System information OS & OS version: Win10 Pro OS theme: Default DPI / HiDPI resolution: Default Firefox or Thunderbird: Firefox Firefox/Thunderbird version: ESR91/Dev100.0b2 Firefox/Thunderbird theme: Dark Settings this issue occurs with: Default

Aris-t2 commented 2 years ago

Not sure how to force the box to appear right now for testing.

Try this code in userChrome.css, it might be the "box":

#tab-notification-deck-template {
  -moz-box-ordinal-group: 100 !important;
}
Sneakpeakcss commented 2 years ago

@Aris-t2

Aminomancer has a nice little code to evoke that notification from console. Depending on FF version:

{let notificationTest=gBrowser.getNotificationBox(gBrowser.selectedBrowser);notificationTest.appendNotification(null,{label:"This is a demo notification",priority:notificationTest.PRIORITY_INFO_HIGH},[{label:"Button 1"},{label:"Link 1",supportPage:"https://github.com/aminomancer/uc.css.js"}])}

or

{let notificationTest = gBrowser.getNotificationBox(gBrowser.selectedBrowser); notificationTest.appendNotification("This is a demo notification", null, null, notificationTest.PRIORITY_INFO_HIGH);}

While #tab-notification-deck-template didn't do anything, #tab-notification-deck seems to work in both ESR91 and DEV100

#tab-notification-deck{
  -moz-box-ordinal-group: 100 !important;
}

image

So from now on that css code seems to be required with tabstoolbar_below_navigation_toolbar.uc.js, unless there's a JavaScript way of doing the same.