[Windows 10 - Thunderbird 60] Windows Task Buttons are Popped out of the Toolbar

[thakyZ]

The windows task buttons (i.e. Close, Minimize, Maximize) on Windows 10, Thunderbird 60, are popped out of the toolbar area by one pixel. I have taken the liberty to fix this myself. All you need to do is patch this line from the main style code:

@media (-moz-windows-compositor)
@media (-moz-os-version: windows-win10)
    @media (-moz-windows-default-theme)
        :root[tabsintitlebar] #navigation-toolbox

With this code:

@media (-moz-windows-compositor) {
@media (-moz-os-version: windows-win10) {
    @media (-moz-windows-default-theme) {
        :root[tabsintitlebar] #navigation-toolbox {
              margin-top: 1px !important;
        }
    }
}
}

It works perfectly fine and also can be patched using a userChrome.css file in the chrome folder of the profile.

[Aris-t2]

Thanks for the fix.

Is this glitch happening with default tabs too or only with "classic squared tabs?

Edit Could you post a screenshot?

[Aris-t2]

Install 2.1.3.1 (test build) and tell me, if the issue is still present for you: https://github.com/Aris-t2/CustomizeMyBird/releases/tag/2.1.3

[thakyZ]

Well I just realized a mistake there was still a border left over from shifting the whole thing down, this is why you shouldn't code late at night.

@media (-moz-windows-compositor) {
  @media (-moz-os-version: windows-win10) {
    @media (-moz-windows-default-theme) {
      :root[tabsintitlebar] #navigation-toolbox {
        margin-top: 0px !important;
      }
      #tabs-toolbar {
        padding-top: 1px !important;
      }
    }
  }
}

Leaves no border and everything is neat

[thakyZ]

EDIT: Your fix doesn't seem to do anything. I forgot to remove my usercontent changes when I backed up the file Also this is for seemingly sizes equal to or greater than 30.

[Aris-t2]

I had some glitches with disabled menubar, so I fixed them in version 2.1.3.1.

Keep in mind there are differences depending on menubar visibility (enabled/disabled) and position (above tabs / below tabs) and also tab height settings. Sometimes minimizing/maximizing the window or restarting Tb after a change help to fix some positions.

Post a screenshot of the problem.

[Aris-t2]

I again replaced 2.1.3.1 and also put it on autoupdate. I could fix caption button position glitches for tab height values above 29px. The overlapping should be gone.

[thakyZ]

As you can see from the picture it does work. Although it's nothing like how Firefox works, but it's a good temporary solution for now Firefox:

[Aris-t2]

Can we close this for now or is "this" still an issue in 2.1.4? I have no plans to handle caption buttons differently than now for tab height values below 32px. "Todays" build of 2.1.4 also allows tab height values of 24px.

Win10s default top/bottom paddings are set to 9px by Thunderbird. CMB overrides the 9px for tab sizes below 32px like this: min(9px,9px - (32px-tabheight)). e.g. Custom tab height of 28px: min(9px,9px - (32px-28px)) = min(9px,5px)) -> 5px (caption buttons top/bottom paddings) Custom tab height of 24px: min(9px,9px - (32px-24px)) = min(9px,1px)) -> 1px (caption buttons top/bottom paddings) Custom tab height of 36px: min(9px,9px - (32px-36px)) = min(9px,13px)) -> 9px (caption buttons top/bottom paddings)

All this works fine on Windows 7-10 and Linux. I have not tested macOS yet.

[thakyZ]

Sure

[Aris-t2]

Thanks, If something comes up again, feel free to reopen this again.