Aris-t2 / NoiaButtons

NoiaButtons for Firefox Quantum
GNU General Public License v3.0
10 stars 2 forks source link

NoiaButtons 3.0.1 and Firefox 121 (Windows 11) #9

Open StavrosTsik opened 9 months ago

StavrosTsik commented 9 months ago

I came across to some bugs(?) with NoiaButtons 3.0.1 and Firefox 121 (Windows 11):

  1. If you have enable the "Dark" theme in Firefox themes, and also enable "noiaui_dark_tabs_below_navigation_toolbar.css" (which I'm currently using), the Search Bar background is all white and cannot see what you type.
  2. If you use "noiaui_dark_tabs_below_navigation_toolbar.css" and "noiaui_dark_separators_between_toolbars.css" in conjunction with Tab Mix Plus v1.0.0-pre.18.20231207.1 extension and having the Multi-Row option enabled, the tab bar IS NOT automatically maximizing, hiding the other tabs below seperator.
  3. Using "Dark" theme in Firefox themes, and also "noiaui_dark_tabs_below_navigation_toolbar.css" the "Close Button" in far right isn't visible (When hoovered with mouse there is a white shadow).
  4. The "New Tab" Button isn't centered (Can be centered ?).

PS. I attached some pictures numbered as the issues above, the "userChrome.css" with the options I'm using and also my monitor settings (in case there is any relation with the above).

1. 1  Search Bar

2. 2  New Tabs

2 1 New Tabs Tab Mix

3. 3  Close Button

4. 4  New Tab Button

  1. userChrome.css userChrome.zip

Monitor: LG 4K 27" with the below settings: Monitor Settings

Aris-t2 commented 9 months ago

1, 3 und 4 are fixed with latest release: https://github.com/Aris-t2/NoiaButtons/releases

2 Can not be fixed. This projects tabs below navigations toolbar are not compatible to multi-row options.

StavrosTsik commented 9 months ago

Thanks for the fixes.. I’ll try them and I will report back (This weekend. I’m away for work 😉).

StavrosTsik commented 9 months ago

Hello @Aris-t2. I've checked the new release. No1 is fixed. No4 is fixed with all options (as shown below in picture in the red rectangle) except "multi-row" option. OK.

2 Can not be fixed. This projects tabs below navigations toolbar are not compatible to multi-row options.

Screenshot 2024-02-03 213000

Screenshot 2024-02-03 210739

No3 is unfortunately still persist with all options above. In userChrome.css the ONLY options I have enabled are: toolbar_buttons_firefox2.css, toolbar_buttons_size_on_navbar_24px.css, noiaui_dark_tabs_below_navigation_toolbar.css. The version of Tab Mix Plus I am using is "1.0.0-pre.18.20231207.1" (https://tabmixplus.org/).

Screenshot 2024-02-03 213403

P.S. I have updated to Firefox 122. The above tested in this version.

EDIT: Also, (last minute's observation) if you press the "List all tabs" button the background is all white and unreadable (I don't know if that has to do with the search bar fix).

Screenshot 2024-02-04 014831

EDIT 2: If I disable the noiaui_dark.css inside the noiaui_dark_tabs_below_navigation_toolbar.css then the above two issues are automatically fixed except that now, the tabs on the Tab Bar that are not selected, are also dark and almost unreadable.

Screenshot 2024-02-04 022650

EDIT 3: I don't know if it is also relevant but besides all of the above options, I have also enabled the "Dark" option in "Settings -> General -> Website appearance".

Aris-t2 commented 7 months ago

Sorry for the late response. Does this test build fix any remaining issues?

noiabuttons_v3.0.2_test20240313.zip

StavrosTsik commented 7 months ago

No worries. I’ll test and post back.

StavrosTsik commented 7 months ago

Hi @Aris-t2. I have tested this test build and all the issues are fixed, except that now the "New Tab" button reverted again back from centered. :confused::confused: Screenshot 2024-03-16 211042

Tested on Firefox versions 121.0, 122.0 and 123.0.1.

Aris-t2 commented 7 months ago

image

Not sure what causes this. Tested on Fx 115 ESR, 123 release, 124 beta and 125 Nightly with compact, normal and touch modes. Maybe there is an incompatibility with TabMixPlus?

StavrosTsik commented 7 months ago

Maybe there is an incompatibility with TabMixPlus?

@Aris-t2 Thanks for the quick response. You've got me thinking. After a lot of testing, the issue of the centered "New Tab" Button was caused by TabMixPlus but not because of some incompatibility with it but a specific option of it. I had installed TabMixPlus prior NoiaButtons and I had imported previous saved settings in which I had enabled the "Multi-row" option, which caused the "New Tab" Button not to be centered.

Screenshot 2024-03-17 215316 Screenshot 2024-03-17 215433

Checking all other "Scrollable..." options, "New Tab" button was working as expected. :wink::wink:

Screenshot 2024-03-17 214634 Screenshot 2024-03-17 214854

P.S After contacting TabMixPlus developer, suggested adding this css rule to userChrome.css for "Multi-row" "New Tab" button centered and it also worked as expected .

#new-tab-button {
  align-self: center;
}

Screenshot 2024-03-17 222423

After all of that, we are safe to say that "noiabuttons_v3.0.2_test20240313.zip" test build fixed the remaining issues.... :wink::wink: