Custom 404 and 500 error pages - Githubissues

AritDevCircle / shiftwork2

Are you a shiftworker looking for last-minute gigs? Or a business owner with open shifts to fill? The Shiftwork app can connect you to shift opportunities or shiftworkers!

https://shiftworkapp.herokuapp.com

2 stars 4 forks source link

Custom 404 and 500 error pages #116

Open Timilehin08 opened 3 years ago

Timilehin08 commented 3 years ago

What type of PR is this? (check all applicable)

[] Feature
[] Refactor
[] Bug Fix
[x] Optimization
[] Documentation Update
[x] Other (describe: Styling )

Description of what PR does

Removes 404 and 500 html file in Public folder and Generates a new ErrorsController that inherits from ApplicationController with command rails g controller errors not_found internal_server_error.
Configures Routes to Handle New Errors Page in config/routes.rb.
Adjusts configuration to turn off the default way Rails will handle errors in the main application.rb file.
Disables configuration in config/environments/development.rb in order to test things out locally.
Styles, edits and adjusts the views within app/views/errors accordingly.

Related PRs and/or Issues (if any)

24

QA Instructions, Screenshots, Recordings

For example, go to http://127.0.0.1:3000/sss to see how error page looks like. https://web-crunch.com/posts/custom-error-page-ruby-on-rails

Added tests?

[x] yes
[ ] no, because they aren't needed (please include reasons for why tests aren't needed)
[ ] no, because I need help
[ ] no, they will be added later (please create an Issue for it)

Added to documentation?

[ ] Yes, project README
[x] No documentation needed

Timilehin08 commented 3 years ago

Hello everyone! I had to create another branch and this PR because resolving the conflict on the other branch/PR was becoming way too problematic than it should be.