AritDeveloperCircle / findyourpeople

MIT License
8 stars 0 forks source link

Ibimina auth guard #132

Closed ibimina closed 1 year ago

ibimina commented 1 year ago

What type of PR is this? (check all applicable)

Description of what this Pull Request does

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

(In this section, describe how to QA/review your PR. Feel free to use screenshots and/or short videos)

Added/updated tests?

msarit commented 1 year ago

@ibimina I may not be testing this PR right but when I start my development server and navigate to /managerDashboard I am able to view the contents without first authenticating.

For testing purposes, I think it would be helpful to include Login and Logout links - no styling, just the links, so that we can properly test the guarding of managerDashboard access. 🙏🏾

ibimina commented 1 year ago

@msarit redirect to landing page fixed, I will add the links to other page

msarit commented 1 year ago

@ibimina Please my dear this PR needs your attention