search

Arize-ai / phoenix-on-azure

Other
12 stars 3 forks source link

windows compatibility and update readme #5

Closed gkulin closed 2 months ago

gkulin commented 2 months ago

Windows Compatibility

After following the steps of the ReadMe, the banner displayed as expected but after following the link to the Phoenix UI, you were prompted to sign into the site. If you entered the credentials, you were prompted again for the credentials. Removing the single quotes from {val} in subprocess.run(f"azd env set {name} '{val}'", shell=True) fixed the issue on Windows but then the infinite auth loop occurred on MacOS instead. Our solution is to call subprocess.run() with more granular commands.

Update README

We also updated the Readme to align with the template readme found in Azure-Samples/azd-template-artifacts. Any feedback on this is welcome :)

kristenwomack commented 2 months ago

Hey @loopingz, can you review this PR please?

loopingz commented 2 months ago

Yes will do, i just needed to merge the README.md with the main branch because I think your modification was done on a previous version

loopingz commented 2 months ago

Merged through PR https://github.com/Arize-ai/phoenix-on-azure/pull/7