Migrate to standalone project [1/2]

ArjanSchouten / HtmlMinifier

Html minifier written in PHP

MIT License

22 stars 1 forks source link

Migrate to standalone project [1/2] #8

Closed flo-sch closed 7 years ago

flo-sch commented 7 years ago

Hey @ArjanSchouten, sorry for the delay, a bit busier than expected...

Drop Illuminate\Contracts and Illuminate\Filesystem use (replaced by standalone PHP)

--> There remains only Illuminate\Support for now, which I will handle in another PR, I first wanted to know what you think about this one?

Laravel\Filesystem has been replaced by custom Exeptions and file_get_contents(), even though SplFileObject could be used instead, if you prefer?

ArjanSchouten commented 7 years ago

Thanks. I see search should be replaced with array_search according to the tests?! Can you fix that?

One other test just failed which is now fixed in the master branch.

flo-sch commented 7 years ago

Of course! I really thought I fixed that part, sorry...

ArjanSchouten commented 7 years ago

Thanks for the PR!