search

ArjunSharda / nextguild

Simplify interactions with the Guilded API
https://pypi.org/project/nextguild/
MIT License
5 stars 6 forks source link

Update client.py send_webhook_message() to match docs #46

Closed Luunae closed 11 months ago

Luunae commented 1 year ago

Specifically: https://github.com/ArjunSharda/nextguild/blob/5c53c5422b6a44838bfd2b279439c5327a33f2a5/nextguild/client.py#L1015-L1028

Per https://github.com/ArjunSharda/nextguild/blob/main/docs/ext/client/webhooks.rst , this function should also accept the optional arguments embeds: list, username: str, and avatar_url: str.

Additionally, content should simultaneously be changed to be optional here, to match the Guilded Webhook API ( https://guildedapi.com/resources/webhook/#jsonform-params ). Possibly with an in-function check to make sure one of content or embeds are provided?

ArjunSharda commented 1 year ago

Hi Luunae!

Thank you for bringing this to the team's attention! I'll work on this and change them. Thank you for reporting this!

Thanks, Arjun

ArjunSharda commented 1 year ago

Update: Issue has been fixed, and will be implemented when pull request #49 is merged for the next update. Thank you to everybody who participated in this.

Issue will be closed upon merge of the pull request.