search

ArjunVachhani / order-matcher

simple, fast and feature rich order matching engine supports limit, market, stop-loss, iceberg, IOC, FOK, GTD orders
MIT License
137 stars 70 forks source link

Can you to add UserId long to Order? #38

Closed P9avel closed 2 years ago

P9avel commented 2 years ago

Hi, i am need UserId in each Order. Can you to add UserId long to Order?

ArjunVachhani commented 2 years ago

At the moment UserId is not used by order-matcher. May I suggest you extending Order class

P9avel commented 2 years ago

I see you. But i am want to use your code as is and update when you will release new version without modification.

P9avel commented 2 years ago

I am need UserId and many users need to have UserId. i am think need add UserId to core and to serializatiors and etc

ArjunVachhani commented 2 years ago

At the moment UserId is not used, It will be needed If we implement Self Match Prevention(#6). If we have UserId property in Order then we might need to expose it to events via ITradeListener as well.

ArjunVachhani commented 2 years ago

@P9avel long-orderId-and-userId branch contains support for UserId and OrderId in long.

P9avel commented 2 years ago

Many many thx for your work