Ark2000 / PankuConsole

Feature-packed real-time debugging toolkit for Godot Engine.
https://k2kra.xyz/PankuConsole/
MIT License
1.07k stars 43 forks source link

Editor freezes on quit when plugin is enabled #114

Closed francoisdlt closed 1 year ago

francoisdlt commented 1 year ago

Describe the bug When the plugin is enabled and I quit the editor, it freezes and stops responding

To Reproduce Steps to reproduce the behavior:

  1. create new project
  2. add panku_console plugin
  3. enable panku_console plugin
  4. quit the editor

Expected behavior the editor should quit normally

Desktop:

Additional context I still get the "Panku Console unloaded" message before it freezes Whenever I disable the plugin, the problem disappears.

Ark2000 commented 1 year ago

what about the latest commit?

francoisdlt commented 1 year ago

still having the same problem :'(

Ark2000 commented 1 year ago

sorry i dont have a mac machine, the only code piece i can think of is the _exit_tree function in plugin.gd since plugin.gd is the only editor script, you can comment out that function to see if it works.

also, try to run godot in verbose mode to get more detailed engine logs, i solved a lot of problems by reading that.

francoisdlt commented 1 year ago

Following your suggestion, I found that commenting the print instruction solves the issue.

Ark2000 commented 1 year ago

Following your suggestion, I found that commenting the print instruction solves the issue.

weird, but thankfully it works.

Ark2000 commented 1 year ago

it is an engine bug introduced by 4.1, confirmed on windows os too, see https://github.com/godotengine/godot/issues/79379

Ark2000 commented 1 year ago

_exit_tree() function was removed and now it should work well.

francoisdlt commented 1 year ago

thanks ! does the mirror repository update automatically ?

Ark2000 commented 1 year ago

thanks ! does the mirror repository update automatically ?

unfortunately not, but I'll later work on this, and I have to manually update mirror repo until now.

Ark2000 commented 1 year ago

https://github.com/Ark2000/PankuConsole/issues/119

francoisdlt commented 1 year ago

I confirm the freeze is gone with the new version and thanks for updating the mirror repo !