search

Ark2000 / PankuConsole

Feature-packed real-time debugging toolkit for Godot Engine.
https://k2kra.xyz/PankuConsole/
MIT License
997 stars 38 forks source link

Option to only show screen overlay when interactive shell is visible #138

Closed Hotklou2404 closed 10 months ago

Hotklou2404 commented 10 months ago

Is your feature request related to a problem? Please describe. It is not related to a problem.

Describe the solution you'd like I want a setting I can toggle to only show the screen overlay when the interactive shell is visible. If this setting is toggled and you close/hide the interactive shell then the overlay will become invisible, even if the screen_overlay setting is true. Of course, if the screen_overlay setting is false, then the overlay will, as usual, not be visible, even if this new setting is toggled.

Describe alternatives you've considered Instead of making a new, separate setting to trigger this behaviour, change the screen_overlay setting to be a dropdown menu with three options instead of a simple yes/no checkbox. Two of the options could be something like Always Show, Never Show, and the third one would be something like Show If Popup or Show If Shell Visible.

Additional context No additional context.

Ark2000 commented 10 months ago
2 4

Thanks for your suggestion, it had been implemented, you can give it a test.

Hotklou2404 commented 10 months ago

@Ark2000 You meant for me to test the newest commit in the "feat" branch, right? I downloaded it, replaced the old addon with the new version, but for some reason now I don't see a screen_overlay setting at all.

dsBuffer bmp

I'm using Godot 4.2.beta5 (see in screenshot), if that helps any?

EDIT 1: I will test it in Godot 4.1 quickly.

EDIT 2: It DOES seem to work absolutely wonderfully in Godot 4.1. It just doesn't work in Godot 4.2.beta5. Before you made this newest change with the dropdown menu and it was still just a checkbox it did work in Godot 4.2 though (and I did use the previous version in the "feat" branch).

Ark2000 commented 10 months ago

it should work now(1eaf10d1645f898d6b3cd18cbb34f35bf39df6ba). something seems changed in 4.2, I have to use a more primitive export style.

Hotklou2404 commented 10 months ago

Yep, it works as expected now.

There aren't any spaces between the words in the names of the latter two options in the dropdown menu though. They read as ShowIfShellVisible and NeverShow, whereas the first option reads as Always Show. Just a tiny nitpick, but once that's fixed I think you can wrap this issue up and mark it as done. :D

Ark2000 commented 10 months ago

Done