search

Ark2000 / PankuConsole

Feature-packed real-time debugging toolkit for Godot Engine.
https://k2kra.xyz/PankuConsole/
MIT License
997 stars 38 forks source link

Move config settings and checks to related module #178

Closed worron closed 3 months ago

worron commented 3 months ago

This PR addresses #177.

Was found that sometimes calling main plugin class PankuConsolePlugin from config module lead to fails in runtime. Happened in exported project reliably and in editor randomly, but later hard to reproduce. As fast solution I tried to move config related code to PankuConfig module and call it from plugin module, and seems it woks fine.

Not sure if it's optimal solution but still suggesting to use it as quick fix.

worron commented 3 months ago

@TheContainer, Can you give it a test please?

TheContainer commented 3 months ago

@TheContainer, Can you give it a test please?

I ran multiple tests I created earlier where the errors occurred, and every test worked fine. So it works for me 👍

Ark2000 commented 3 months ago

Sorry for the late reply, I tested it and it works fine for me.