search

ArkEcosystem / AIPs

ARK Improvement Proposals
26 stars 25 forks source link

AIP-29 - Generic Transactions discussion #64

Closed kristjank closed 3 years ago

Nigui commented 5 years ago

Are apply and revert methods of transaction handler deliberately omitted ? If so, how can we specify modifications of the current blockchain state ?

kristjank commented 5 years ago

Good question, this is still WIP so we will also get to remodelling this part, which could also be part of the new AIP structure, related to overall integration into the wallet manager and validation mechanics.

Nigui commented 5 years ago

Why canApply is synchronous ? What if I need to do asynchronous operations to verify transaction application ? In my use-case, I want to call database in the canApply function and db uses pg-promise to query, which is fully async.

spkjp commented 5 years ago

@Nigui Thanks for the feedback. Initially the idea was to only allow synchronous operations because it reduces the risk of performing any expensive tasks. Triggering the database will degrade the overall throughput of such transactions. Anyway, I agree that there are use cases which require asynchronous operations, but cannot be realized due to this limitation. We will look into it!

github-actions[bot] commented 3 years ago

Stale issue message