refactor: clean up votes page - Githubissues

ArkEcosystem / desktop-wallet

:computer: Archived, please use ARKVault

https://app.arkvault.io

MIT License

292 stars 191 forks source link

refactor: clean up votes page #3991

Closed goga-m closed 3 years ago

goga-m commented 3 years ago

Summary

[x] Move vote page sections as subcomponents into separate files (VotesHeader, VotesEmpty, VotingWallets)
[x] Improve readability by moving code into respective hooks (useVoteVilters, useDelegates, useVoteActions, useVoteQueryParams
[x] Fix issue with not showing empty results screen when changing filters.
[x] Clean up sub component rendering conditionals, and reduce nesting.
[x] Cleanup Votes.tsx

Checklist

[x] My changes look good in both light AND dark mode
[x] The change is not hardcoded to a single network, but has multi-asset in mind
[x] I checked my changes for obvious issues, debug statements and commented code
[ ] Documentation (if necessary)
[x] Tests (if necessary)
[x] Ready to be merged

faustbrian commented 3 years ago

Task linked: CU-n37cpk [Votes] Show no-results screen instead of white screen when using filter dropdown