search

ArkEcosystemArchive / cpp-crypto

A simple Cryptography Implementation in C++ for the Ark Blockchain.
MIT License
13 stars 10 forks source link

Add support for the Cortex M4 chipset #187

Closed ciband closed 4 years ago

ciband commented 5 years ago

Expected Behavior Supporting the Cortex M4 processor would be good.

Current Behavior The Cortex M4 is not currently supported.

Possible Solution Support the Cortex M4.

ghost commented 5 years ago

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

sleepdefic1t commented 5 years ago

Ooh, this is a good one, @ciband

I'm in favor of this. There are quite a few M4(ATSAMD51) boards out there, and it looks to sit somewhere between the ESP8266 & ESP32. To what extent, I'm not sure, but it also has ECC crypto support.

I've also got an M4 board on-hand to help with testing as well.

There's no formal process for adding boards atm, but I'll start putting something together so we can standardize everything for future contributions.

In the mean time, I think it would be helpful if you can make a basic milestone list of what's needed to implement this.

Once a checklist is mapped out and discussed, we can move forward with creating another feature branch 👍

ciband commented 5 years ago

Sure. With the attached PR the basics are already there.

For the initial support I think that would be it. If I understand the goals of the platform support packages, that would be where we would add specialized support for the native ECC crypto stuff, right?

@sleepdefic1t , Are there things you would like added to this list?

sleepdefic1t commented 5 years ago

@ciband

Yes, native type stuff can come once we can do support packages. In a sense, most of the board stuff doesn't really have much to do the SDK's, or at least shouldn't. Eventually, the support packages should basically just house primitives tied to a given platform, where the ARK SDK's would just call those methods instead of handling all the targets dependencies.

The list looks good. I think that should be good enough ATM.

Let me know when you're ready, I'll create a feat branch.

Feel free to contribute to this doc too. This issue doesn't have to adhere to the doc, it's still WIP; but you may have some insights that would be useful in mapping out board contribution guidelines. https://hackmd.io/@sleepdefic1t/SJxsInlor

ciband commented 5 years ago

@sleepdefic1t I'm ready when you are for a feature branch.

sleepdefic1t commented 5 years ago

@ciband

https://github.com/ArkEcosystem/cpp-crypto/tree/feat/boards/m4

ciband commented 5 years ago

@sleepdefic1t Initial commits pushed

ciband commented 5 years ago

@sleepdefic1t feature branch rebased with latest changes from develop

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sleepdefic1t commented 4 years ago

Closing for now, it can be reopened when needed.

ghost commented 4 years ago

This issue has been closed. If you wish to re-open it please provide additional information.