search

ArkEcosystemArchive / cpp-crypto

A simple Cryptography Implementation in C++ for the Ark Blockchain.
MIT License
13 stars 10 forks source link

Chore/reduce build times #192

Closed ciband closed 5 years ago

ciband commented 5 years ago

Summary

Reworked PIO build system to collapse a lot of the configuration and inherit common configurations.

This reduces build times by not having the frameworks built for every PIO project.

Checklist

ghost commented 5 years ago

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

ciband commented 5 years ago

@sleepdefic1t @faustbrian

It looks like my .github CI changes are not being picked up by CI.

Any idea why that would be?

sleepdefic1t commented 5 years ago

@ciband Yeah, for whatever reason, GH isn't picking up changes to the the pio CI script.

https://github.com/ArkEcosystem/cpp-crypto/pull/192/checks?check_run_id=303709220#step:4:2

Run platformio run
platformio run
platformio run -d ./test
shell: /bin/bash -e {0}
Processing esp8266 (platform: espressif8266; board: huzzah; framework: arduino)

I tried updating the file, forking and pushing this branch to my remote for a PR, and nada. Still reading the old script.

I just updated from the branch of your other PR. If it still doesn't pass in time, I'll approve and merge this. There's no other reason for it to not work besides GH Actions 💩

ghost commented 5 years ago

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

ghost commented 5 years ago

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

sleepdefic1t commented 5 years ago

https://github.com/ArkEcosystem/cpp-crypto/runs/304088659#step:4:2

Run platformio run
platformio run
platformio run -d ./test
shell: /bin/bash -e {0}
Processing esp8266 (platform: espressif8266; board: huzzah; framework: arduino)

ghost commented 4 years ago

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.